Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the missing CheckReturnValue annotations to the Multi replay operator API #876

Merged
merged 1 commit into from
Mar 17, 2022

Conversation

jponge
Copy link
Member

@jponge jponge commented Mar 17, 2022

Fixes #874

@jponge jponge requested a review from cescoffier March 17, 2022 07:39
@jponge jponge added the bug Something isn't working label Mar 17, 2022
@jponge jponge added this to the 1.5.0 milestone Mar 17, 2022
@codecov
Copy link

codecov bot commented Mar 17, 2022

Codecov Report

Merging #876 (9e2e9b3) into main (ff046d8) will increase coverage by 0.33%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #876      +/-   ##
============================================
+ Coverage     89.12%   89.45%   +0.33%     
- Complexity     3072     3085      +13     
============================================
  Files           386      386              
  Lines         12354    12354              
  Branches       1574     1576       +2     
============================================
+ Hits          11010    11051      +41     
+ Misses          705      680      -25     
+ Partials        639      623      -16     
Impacted Files Coverage Δ
...in/java/io/smallrye/mutiny/groups/MultiReplay.java 100.00% <ø> (ø)
...y/operators/multi/processors/UnicastProcessor.java 95.68% <0.00%> (-1.73%) ⬇️
...tiny/operators/multi/MultiBufferWithTimeoutOp.java 73.10% <0.00%> (-1.69%) ⬇️
...mallrye/mutiny/operators/multi/MultiFlatMapOp.java 84.19% <0.00%> (-0.92%) ⬇️
...allrye/mutiny/operators/uni/UniAndCombination.java 90.19% <0.00%> (+0.98%) ⬆️
...erators/multi/builders/SerializedMultiEmitter.java 80.48% <0.00%> (+1.21%) ⬆️
...mallrye/mutiny/helpers/queues/MpscLinkedQueue.java 98.38% <0.00%> (+1.61%) ⬆️
...java/io/smallrye/mutiny/helpers/Subscriptions.java 81.76% <0.00%> (+2.76%) ⬆️
...mallrye/mutiny/operators/multi/FlatMapManager.java 98.61% <0.00%> (+2.77%) ⬆️
...ny/operators/uni/builders/UniCreateFromFuture.java 92.85% <0.00%> (+3.57%) ⬆️
... and 7 more

Copy link
Contributor

@cescoffier cescoffier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@cescoffier cescoffier merged commit c881740 into main Mar 17, 2022
@cescoffier cescoffier deleted the bug/missing-replay-checkreturnvalue-annotation branch March 17, 2022 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MultiReplay misses @CheckReturnValue annotations
2 participants