New Multi demand pacing operator #875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
jponge
commented
Mar 17, 2022
implementation/src/main/java/io/smallrye/mutiny/operators/multi/MultiDemandPacer.java
Outdated
Show resolved
Hide resolved
jponge
commented
Mar 17, 2022
implementation/src/main/java/io/smallrye/mutiny/operators/multi/MultiDemandPacer.java
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## main #875 +/- ##
============================================
+ Coverage 89.17% 89.20% +0.02%
- Complexity 3074 3089 +15
============================================
Files 386 390 +4
Lines 12354 12446 +92
Branches 1574 1587 +13
============================================
+ Hits 11017 11102 +85
- Misses 703 706 +3
- Partials 634 638 +4
|
cescoffier
approved these changes
Mar 17, 2022
| * Downstream demand requests are being ignored, so it is possible that this operator requests more than what the downstream | ||
| * subscriber would want, depending on the {@link io.smallrye.mutiny.subscription.DemandPacer} | ||
| * object in use. | ||
| * |
There was a problem hiding this comment.
Should we mention onOVerflow()?
implementation/src/main/java/io/smallrye/mutiny/operators/multi/MultiDemandPacer.java
Show resolved
Hide resolved
implementation/src/main/java/io/smallrye/mutiny/subscription/DemandPacer.java
Show resolved
Hide resolved
Demand pacing can be controlled from previous demands and the number of emitted items since the last request. The initial implementation ships with a fixed demand implementation of the demand pacing interface. Users can easily define their own policies, and we can introduce other concrete implementations in the future given use-cases and patterns. This operator is not reactive-streams compliant because the downstream demand has to be ignored. See #872
Co-authored-by: Clement Escoffier <[email protected]>
jponge
force-pushed
the
feature/subscription-pacing
branch
from
0f5ee57 to
b939caa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Demand pacing can be controlled from previous demands and the number of emitted items since the last request.
The initial implementation ships with a fixed demand implementation of the demand pacing interface.
Users can easily define their own policies, and we can introduce other concrete implementations in the future given use-cases and patterns.
This operator is not reactive-streams compliant because the downstream demand has to be ignored.
See #872