Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid overflow when using ChronoUnit.FOREVER with the memoize operator #863

Merged
merged 1 commit into from
Mar 9, 2022

Conversation

cescoffier
Copy link
Contributor

Fix #862.

@cescoffier cescoffier requested a review from jponge March 9, 2022 07:18
@cescoffier cescoffier added this to the 1.6.0 milestone Mar 9, 2022
@cescoffier cescoffier added the bug Something isn't working label Mar 9, 2022
@codecov
Copy link

codecov bot commented Mar 9, 2022

Codecov Report

Merging #863 (7f18f23) into main (8e1d9a7) will increase coverage by 0.24%.
The diff coverage is 100.00%.

❗ Current head 7f18f23 differs from pull request most recent head 10f7df6. Consider uploading reports for the commit 10f7df6 to get more accurate results

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #863      +/-   ##
============================================
+ Coverage     89.06%   89.31%   +0.24%     
- Complexity     3048     3067      +19     
============================================
  Files           383      383              
  Lines         12185    12188       +3     
  Branches       1547     1550       +3     
============================================
+ Hits          10853    10886      +33     
+ Misses          701      683      -18     
+ Partials        631      619      -12     
Impacted Files Coverage Δ
...ain/java/io/smallrye/mutiny/groups/UniMemoize.java 100.00% <100.00%> (ø)
...utiny/operators/multi/MultiWindowOnDurationOp.java 65.71% <0.00%> (-5.72%) ⬇️
...main/kotlin/io/smallrye/mutiny/coroutines/Multi.kt 80.95% <0.00%> (-4.77%) ⬇️
...tiny/operators/multi/MultiBufferWithTimeoutOp.java 73.10% <0.00%> (-1.69%) ⬇️
...mallrye/mutiny/operators/multi/MultiFlatMapOp.java 85.10% <0.00%> (+0.91%) ⬆️
...smallrye/mutiny/helpers/test/AssertSubscriber.java 91.17% <0.00%> (+1.47%) ⬆️
...java/io/smallrye/mutiny/helpers/Subscriptions.java 80.66% <0.00%> (+1.65%) ⬆️
...y/operators/multi/processors/UnicastProcessor.java 97.41% <0.00%> (+1.72%) ⬆️
...io/smallrye/mutiny/operators/uni/UniMemoizeOp.java 93.20% <0.00%> (+1.94%) ⬆️
...erators/multi/builders/SerializedMultiEmitter.java 81.70% <0.00%> (+2.43%) ⬆️
... and 6 more

@jponge jponge modified the milestones: 1.6.0, 1.4.0 Mar 9, 2022
Copy link
Member

@jponge jponge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@jponge
Copy link
Member

jponge commented Mar 9, 2022

@cescoffier would you mind signing your commit? (I've added this requirement in branch protection recently)

See git config --global commit.gpgsign true

@jponge jponge enabled auto-merge March 9, 2022 08:45
@cescoffier cescoffier force-pushed the fix-memoize-forever branch from 10f7df6 to 31a7147 Compare March 9, 2022 10:55
@jponge jponge merged commit da99f8d into smallrye:main Mar 9, 2022
@cescoffier cescoffier deleted the fix-memoize-forever branch March 9, 2022 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Long overflow when using memoize() with ChronoUnit.FOREVER.getDuration()
2 participants