JPMS open modules do not export packages #836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We incorrectly assumed that open modules would export all packages, which is not the case. - Open modules allow for (deep) reflection to all classes, which is something we want to allow. We have no good reason right now to restrict reflection in Mutiny. - Exported packages need to be added manually, there is no wildcard. I did a selection of packages that shall be in the public API. - I fixed transitive 'requires' clauses: Reactive Streams is part of the Mutiny API, just like SmallRye Common Annotations.
Codecov Report
@@ Coverage Diff @@
## main #836 +/- ##
============================================
+ Coverage 89.08% 89.18% +0.09%
- Complexity 3052 3055 +3
============================================
Files 383 383
Lines 12185 12185
Branches 1547 1549 +2
============================================
+ Hits 10855 10867 +12
+ Misses 697 694 -3
+ Partials 633 624 -9
|
cescoffier
approved these changes
Jan 31, 2022
|
AbstractUni and AbstractMulti are definitely part of the public API (advanced use case where you need to implement your own operator). We use them in Reactive Messaging. I know that the Cassandra Quarkus extension is also using them. |
|
@cescoffier See the latest changes to align RevAPI and the module descriptor |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We incorrectly assumed that open modules would export all packages, which is not the case.