Avoid Uni.join().first(unis).toTerminate() with a concurrency limit
#831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jponge
changed the title
Uni.join().first(unis) with a concurrency limitUni.join().first(unis).toTerminate() with a concurrency limit
Also removed dropped exception logging, cancellation on a join effectively means that failures shall be discarded.
jponge
force-pushed
the
feature/uni-join-no-concurrency-limit-on-first-to-terminate
branch
from
0f08c8b to
f7db080
Compare
Codecov Report
@@ Coverage Diff @@
## main #831 +/- ##
============================================
+ Coverage 89.00% 89.16% +0.15%
- Complexity 3050 3056 +6
============================================
Files 383 383
Lines 12175 12169 -6
Branches 1541 1544 +3
============================================
+ Hits 10836 10850 +14
+ Misses 710 696 -14
+ Partials 629 623 -6
|
jponge
commented
Jan 28, 2022
| @@ -29,6 +28,7 @@ public UniJoinFirst(List<Uni<T>> unis, Mode mode, int concurrency) { | |||
| this.unis = unis; | |||
| this.mode = mode; | |||
| this.concurrency = concurrency; | |||
| assert (mode == Mode.FIRST_WITH_ITEM || (mode == Mode.FIRST_TO_EMIT && concurrency == -1)); // Invariant enforced by the caller DSL | |||
There was a problem hiding this comment.
Note: Maven Surefire enables assertions by default. It's really an invariant worth checking in tests, not at runtime.
cescoffier
approved these changes
Jan 29, 2022
jponge
deleted the
feature/uni-join-no-concurrency-limit-on-first-to-terminate
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also removed dropped exception logging, cancellation on a join effectively means that failures shall be discarded.