Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit concurrency in Uni.combine().all() #829

Merged

Conversation

jponge
Copy link
Member

@jponge jponge commented Jan 28, 2022

Note: Uni.combine().any() must not support concurrent limits, because the semantic is to forward the result of the fastest Uni (item or failure).

@codecov
Copy link

codecov bot commented Jan 28, 2022

Codecov Report

Merging #829 (baa095a) into main (50dcb78) will increase coverage by 0.12%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #829      +/-   ##
============================================
+ Coverage     89.00%   89.13%   +0.12%     
- Complexity     3050     3056       +6     
============================================
  Files           383      383              
  Lines         12175    12191      +16     
  Branches       1541     1548       +7     
============================================
+ Hits          10836    10866      +30     
+ Misses          710      702       -8     
+ Partials        629      623       -6     
Impacted Files Coverage Δ
...io/smallrye/mutiny/groups/UniAndGroupIterable.java 100.00% <100.00%> (ø)
...allrye/mutiny/operators/uni/UniAndCombination.java 90.19% <100.00%> (+1.43%) ⬆️
...mallrye/mutiny/helpers/queues/MpscLinkedQueue.java 90.32% <0.00%> (-8.07%) ⬇️
...mallrye/mutiny/operators/multi/MultiFlatMapOp.java 84.19% <0.00%> (-0.92%) ⬇️
...erators/multi/builders/SerializedMultiEmitter.java 80.48% <0.00%> (+1.21%) ⬆️
...smallrye/mutiny/helpers/test/AssertSubscriber.java 91.17% <0.00%> (+1.47%) ⬆️
...io/smallrye/mutiny/operators/uni/UniMemoizeOp.java 93.20% <0.00%> (+1.94%) ⬆️
...subscription/SwitchableSubscriptionSubscriber.java 97.60% <0.00%> (+2.39%) ⬆️
...lrye/mutiny/subscription/SerializedSubscriber.java 88.07% <0.00%> (+2.75%) ⬆️
...mallrye/mutiny/operators/multi/FlatMapManager.java 98.61% <0.00%> (+2.77%) ⬆️
... and 3 more

@jponge jponge linked an issue Jan 28, 2022 that may be closed by this pull request
@jponge jponge marked this pull request as ready for review January 28, 2022 20:55
@jponge jponge added this to the 1.4.0 milestone Jan 28, 2022
@jponge jponge added the enhancement New feature or request label Jan 28, 2022
@jponge jponge requested a review from cescoffier January 28, 2022 20:56
@cescoffier cescoffier merged commit 26e1499 into smallrye:main Jan 29, 2022
@jponge jponge deleted the feature/uni-combine-limit-concurrency branch January 30, 2022 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Uni.{join,combine} shall limit concurrency
2 participants