Limit Uni.join().{all,first}() concurrency #825
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #825 +/- ##
============================================
+ Coverage 88.83% 89.05% +0.22%
- Complexity 3044 3051 +7
============================================
Files 383 383
Lines 12133 12175 +42
Branches 1526 1543 +17
============================================
+ Hits 10778 10843 +65
+ Misses 722 707 -15
+ Partials 633 625 -8
|
Make sure we can't chain multiple withConcurrencyLimit(n) calls.
|
(need to add a few more tests) |
cescoffier
requested changes
Jan 25, 2022
implementation/src/main/java/io/smallrye/mutiny/operators/uni/builders/UniJoinAll.java
Show resolved
Hide resolved
implementation/src/main/java/io/smallrye/mutiny/operators/uni/builders/UniJoinAll.java
Show resolved
Hide resolved
| @@ -96,6 +119,11 @@ private void onFailure(Throwable failure) { | |||
| if (failures.size() == unis.size()) { | |||
| cancelled.set(true); | |||
| subscriber.onFailure(new CompositeException(failures)); | |||
| } else if (concurrency != -1) { | |||
| int nextIndex = nextSubscriptionIndex.incrementAndGet(); | |||
| if (nextIndex < unis.size()) { | |||
There was a problem hiding this comment.
Same comment here - we need to check for cancellation before doing the subscription.
There was a problem hiding this comment.
@jponge it needs to check for cancellation too.
cescoffier
requested changes
Jan 26, 2022
| @@ -96,6 +119,11 @@ private void onFailure(Throwable failure) { | |||
| if (failures.size() == unis.size()) { | |||
| cancelled.set(true); | |||
| subscriber.onFailure(new CompositeException(failures)); | |||
| } else if (concurrency != -1) { | |||
| int nextIndex = nextSubscriptionIndex.incrementAndGet(); | |||
| if (nextIndex < unis.size()) { | |||
There was a problem hiding this comment.
@jponge it needs to check for cancellation too.
cescoffier
approved these changes
Jan 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.