Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a Kotlin test timing issue due to slow starting coroutines #824

Merged
merged 1 commit into from
Jan 24, 2022

Conversation

jponge
Copy link
Member

@jponge jponge commented Jan 24, 2022

No description provided.

@jponge jponge requested a review from heubeck January 24, 2022 11:34
@jponge jponge added the bug Something isn't working label Jan 24, 2022
@jponge jponge linked an issue Jan 24, 2022 that may be closed by this pull request
@jponge jponge added this to the 1.4.0 milestone Jan 24, 2022
@codecov
Copy link

codecov bot commented Jan 24, 2022

Codecov Report

Merging #824 (75f9166) into main (6dd29ab) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #824      +/-   ##
============================================
+ Coverage     89.12%   89.14%   +0.01%     
- Complexity     3055     3058       +3     
============================================
  Files           383      383              
  Lines         12131    12133       +2     
  Branches       1525     1528       +3     
============================================
+ Hits          10812    10816       +4     
- Misses          700      701       +1     
+ Partials        619      616       -3     
Impacted Files Coverage Δ
...smallrye/mutiny/infrastructure/Infrastructure.java 68.88% <100.00%> (+0.34%) ⬆️
...utiny/operators/multi/MultiWindowOnDurationOp.java 65.71% <0.00%> (-4.29%) ⬇️
...java/io/smallrye/mutiny/helpers/Subscriptions.java 79.00% <0.00%> (-2.77%) ⬇️
.../io/smallrye/mutiny/helpers/queues/DrainUtils.java 82.22% <0.00%> (ø)
...operators/multi/builders/CollectionBasedMulti.java 93.54% <0.00%> (ø)
...mallrye/mutiny/operators/multi/MultiFlatMapOp.java 85.10% <0.00%> (+0.30%) ⬆️
...allrye/mutiny/operators/uni/UniAndCombination.java 89.88% <0.00%> (+1.12%) ⬆️
...perators/multi/processors/SerializedProcessor.java 94.05% <0.00%> (+1.98%) ⬆️
...mallrye/mutiny/operators/multi/FlatMapManager.java 95.83% <0.00%> (+2.77%) ⬆️
...subscription/SwitchableSubscriptionSubscriber.java 97.60% <0.00%> (+4.00%) ⬆️
... and 1 more

@jponge jponge merged commit c583ae4 into main Jan 24, 2022
@jponge jponge deleted the bug/kotlin-flow-cancellation-flakiness branch January 24, 2022 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MultiAsFlowTest flaky test in CI
2 participants