Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RevAPI filtering new syntax #815

Merged
merged 1 commit into from
Jan 17, 2022
Merged

Conversation

jponge
Copy link
Member

@jponge jponge commented Jan 17, 2022

No description provided.

@jponge jponge added this to the 1.4.0 milestone Jan 17, 2022
@jponge jponge requested a review from cescoffier January 17, 2022 17:36
@jponge jponge added bug Something isn't working ci/cd/build CI/CD pipeline and build labels Jan 17, 2022
@jponge
Copy link
Member Author

jponge commented Jan 17, 2022

Did a quick breaking change test, works for me:

{
  "ignore": true,
  "code": "java.method.removed",
  "old": "method io.smallrye.mutiny.Context io.smallrye.mutiny.Context::empty()",
  "justification": "ADD YOUR EXPLANATION FOR THE NECESSITY OF THIS CHANGE"
  /*  "package": "io.smallrye.mutiny",
  "classQualifiedName": "io.smallrye.mutiny.Context",
  "classSimpleName": "Context",
  "methodName": "empty",
  "elementKind": "method",
  "oldArchive": "io.smallrye.reactive:mutiny:jar:1.3.0",
  "oldArchiveRole": "primary",
  */

@jponge
Copy link
Member Author

jponge commented Jan 17, 2022

Seems we're back to flaky tests in CI for a few days:

Error: Exception in thread "pool-40742-thread-96" java.util.concurrent.RejectedExecutionException: Task java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask@2c4526da rejected from java.util.concurrent.ThreadPoolExecutor@5458d383[Terminated, pool size = 0, active threads = 0, queued tasks = 0, completed tasks = 2131]
	at java.util.concurrent.ThreadPoolExecutor$AbortPolicy.rejectedExecution(ThreadPoolExecutor.java:2063)
	at java.util.concurrent.ThreadPoolExecutor.reject(ThreadPoolExecutor.java:830)

(MutinySchedulerTest)

@jponge
Copy link
Member Author

jponge commented Jan 17, 2022

On the Kotlin side:

INFO] 
[INFO] -------------------------------------------------------
[INFO]  T E S T S
[INFO] -------------------------------------------------------
[INFO] Running io.smallrye.mutiny.coroutines.DeferredAsUniTest
[INFO] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.007 s - in io.smallrye.mutiny.coroutines.DeferredAsUniTest
[INFO] Running io.smallrye.mutiny.coroutines.UniAwaitSuspendingTest
[INFO] Tests run: 8, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.748 s - in io.smallrye.mutiny.coroutines.UniAwaitSuspendingTest
[INFO] Running io.smallrye.mutiny.coroutines.FlowAsMultiTest
Error:  Tests run: 6, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 10.712 s <<< FAILURE! - in io.smallrye.mutiny.coroutines.FlowAsMultiTest
Error:  io.smallrye.mutiny.coroutines.FlowAsMultiTest.verify that coroutine cancellation result in failure  Time elapsed: 10.424 s  <<< FAILURE!
java.lang.AssertionError: No completion (or failure) event received in the last 10000 ms

[INFO] Running io.smallrye.mutiny.coroutines.MultiAsFlowTest
[INFO] Tests run: 16, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.939 s - in io.smallrye.mutiny.coroutines.MultiAsFlowTest
[INFO] 
[INFO] Results:
[INFO] 
Error:  Failures: 
Error:    FlowAsMultiTest.verify that coroutine cancellation result in failure No completion (or failure) event received in the last 10000 ms
[INFO] 
Error:  Tests run: 36, Failures: 1, Errors: 0, Skipped: 0

@codecov
Copy link

codecov bot commented Jan 17, 2022

Codecov Report

Merging #815 (81e67bc) into main (6767eac) will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #815      +/-   ##
============================================
+ Coverage     89.21%   89.26%   +0.04%     
+ Complexity     3068     3067       -1     
============================================
  Files           383      383              
  Lines         12129    12129              
  Branches       1527     1527              
============================================
+ Hits          10821    10827       +6     
+ Misses          695      691       -4     
+ Partials        613      611       -2     
Impacted Files Coverage Δ
...perators/multi/processors/SerializedProcessor.java 89.10% <0.00%> (-5.95%) ⬇️
...erators/multi/builders/SerializedMultiEmitter.java 81.70% <0.00%> (-3.66%) ⬇️
...mallrye/mutiny/helpers/queues/MpscLinkedQueue.java 98.38% <0.00%> (-1.62%) ⬇️
...mallrye/mutiny/operators/multi/MultiFlatMapOp.java 85.41% <0.00%> (-0.31%) ⬇️
...main/kotlin/io/smallrye/mutiny/coroutines/Multi.kt 80.95% <0.00%> (ø)
...lrye/mutiny/subscription/SerializedSubscriber.java 87.15% <0.00%> (+1.83%) ⬆️
...mallrye/mutiny/operators/multi/FlatMapManager.java 98.61% <0.00%> (+2.77%) ⬆️
...iny/operators/multi/builders/BaseMultiEmitter.java 84.31% <0.00%> (+3.92%) ⬆️
...utiny/operators/multi/MultiWindowOnDurationOp.java 75.00% <0.00%> (+5.00%) ⬆️
.../io/smallrye/mutiny/helpers/queues/DrainUtils.java 86.66% <0.00%> (+8.88%) ⬆️

@cescoffier cescoffier merged commit 6e0581d into main Jan 17, 2022
@cescoffier cescoffier deleted the build/revapi-new-syntax-fixes branch January 17, 2022 18:47
@jponge jponge modified the milestones: 1.4.0, 1.3.1 Jan 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ci/cd/build CI/CD pipeline and build
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants