Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation for Uni.map incorrect #636

Merged
merged 1 commit into from
Jul 22, 2021
Merged

Conversation

edeandrea
Copy link
Contributor

The documentation for the Uni.map method states This method is equivalent to {@code uni.onItem().apply(x -> ...)}. This is incorrect. It should be This method is equivalent to {@code uni.onItem().transform(x -> ...)}

The documentation for the `Uni.map` method states `This method is equivalent to {@code uni.onItem().apply(x -> ...)}`. This is incorrect. It should be `This method is equivalent to {@code uni.onItem().transform(x -> ...)}`
@codecov
Copy link

codecov bot commented Jul 22, 2021

Codecov Report

Merging #636 (6f315f2) into main (666e3a7) will increase coverage by 0.43%.
The diff coverage is n/a.

❗ Current head 6f315f2 differs from pull request most recent head 2171185. Consider uploading reports for the commit 2171185 to get more accurate results
Impacted file tree graph

@@             Coverage Diff              @@
##               main     #636      +/-   ##
============================================
+ Coverage     89.90%   90.33%   +0.43%     
- Complexity     3018     3034      +16     
============================================
  Files           395      395              
  Lines         11829    11829              
  Branches       1478     1480       +2     
============================================
+ Hits          10635    10686      +51     
+ Misses          618      582      -36     
+ Partials        576      561      -15     
Impacted Files Coverage Δ
...entation/src/main/java/io/smallrye/mutiny/Uni.java 96.66% <ø> (ø)
...ava/io/smallrye/mutiny/helpers/HalfSerializer.java 77.77% <0.00%> (-11.12%) ⬇️
...erators/multi/builders/BufferItemMultiEmitter.java 90.78% <0.00%> (-1.32%) ⬇️
...mallrye/mutiny/operators/multi/MultiFlatMapOp.java 85.66% <0.00%> (+0.93%) ⬆️
...lrye/mutiny/subscription/SerializedSubscriber.java 90.56% <0.00%> (+0.94%) ⬆️
...smallrye/mutiny/operators/multi/MultiEmitOnOp.java 90.47% <0.00%> (+0.95%) ⬆️
...mallrye/mutiny/helpers/queues/MpscLinkedQueue.java 100.00% <0.00%> (+1.61%) ⬆️
...java/io/smallrye/mutiny/helpers/Subscriptions.java 80.66% <0.00%> (+1.65%) ⬆️
...y/operators/multi/processors/UnicastProcessor.java 97.34% <0.00%> (+1.76%) ⬆️
...io/smallrye/mutiny/operators/uni/UniMemoizeOp.java 95.04% <0.00%> (+1.98%) ⬆️
... and 8 more

@edeandrea
Copy link
Contributor Author

I'm not sure how my change impacts any code coverage. My update was only to a Javadoc comment...

@jponge jponge added this to the 1.0.0 milestone Jul 22, 2021
@jponge jponge added the documentation Improvements or additions to documentation label Jul 22, 2021
@jponge
Copy link
Member

jponge commented Jul 22, 2021

Thanks!

Code coverage measures fluctuates for some reasons, @cescoffier and I have become used to deltas 😆

@jponge jponge merged commit 19bf152 into smallrye:main Jul 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants