Simplify Uni to Multi bridge (again) #632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jponge
added
enhancement
cescoffier
approved these changes
Jul 20, 2021
| import io.smallrye.mutiny.operators.AbstractUni; | ||
| import io.smallrye.mutiny.subscription.UniSubscriber; | ||
| import io.smallrye.mutiny.subscription.UniSubscription; | ||
|
|
||
| public final class UniToMultiPublisher<T> extends AbstractMulti<T> { | ||
| public final class UniToMultiPublisher<T> implements Publisher<T> { |
There was a problem hiding this comment.
What's the reason to not be a Multi directly?
There was a problem hiding this comment.
I thought it's safer to have the Infrastructure involved again
Codecov Report
@@ Coverage Diff @@
## main #632 +/- ##
============================================
+ Coverage 89.95% 90.26% +0.30%
- Complexity 3016 3028 +12
============================================
Files 395 395
Lines 11829 11825 -4
Branches 1478 1480 +2
============================================
+ Hits 10641 10674 +33
+ Misses 611 588 -23
+ Partials 577 563 -14
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.