-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convenience combinedWith method with a class cast #558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See #461 |
cescoffier
approved these changes
May 12, 2021
The failure is related:
|
See the discussions in #461
jponge
force-pushed
the
feature/uni-combineWith-cast
branch
from
May 12, 2021 13:53
70e46b8
to
9f67795
Compare
The joy of Java 8 vs 11 |
Codecov Report
@@ Coverage Diff @@
## main #558 +/- ##
============================================
+ Coverage 89.67% 90.00% +0.33%
- Complexity 2915 2928 +13
============================================
Files 380 380
Lines 11513 11516 +3
Branches 1450 1452 +2
============================================
+ Hits 10324 10365 +41
+ Misses 610 590 -20
+ Partials 579 561 -18 |
Dot not merge yet |
Approved with user story |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.