Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convenience combinedWith method with a class cast #558

Merged
merged 2 commits into from
May 19, 2021

Conversation

jponge
Copy link
Member

@jponge jponge commented May 12, 2021

No description provided.

@jponge
Copy link
Member Author

jponge commented May 12, 2021

See #461

@jponge jponge added the enhancement New feature or request label May 12, 2021
@cescoffier
Copy link
Contributor

The failure is related:

Received a failure event, but expecting:
  <java.lang.Integer cannot be cast to java.lang.CharSequence>
to contain:
  <cannot be cast to class java.lang.CharSequence>
but was:
  <java.lang.ClassCastException: java.lang.Integer cannot be cast to java.lang.CharSequence

@jponge jponge force-pushed the feature/uni-combineWith-cast branch from 70e46b8 to 9f67795 Compare May 12, 2021 13:53
@jponge
Copy link
Member Author

jponge commented May 12, 2021

The failure is related:

Received a failure event, but expecting:
  <java.lang.Integer cannot be cast to java.lang.CharSequence>
to contain:
  <cannot be cast to class java.lang.CharSequence>
but was:
  <java.lang.ClassCastException: java.lang.Integer cannot be cast to java.lang.CharSequence

The joy of Java 8 vs 11

@jponge jponge added this to the 0.18.0 milestone May 12, 2021
@jponge jponge linked an issue May 12, 2021 that may be closed by this pull request
@codecov
Copy link

codecov bot commented May 12, 2021

Codecov Report

Merging #558 (7d2f032) into main (5378833) will increase coverage by 0.33%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #558      +/-   ##
============================================
+ Coverage     89.67%   90.00%   +0.33%     
- Complexity     2915     2928      +13     
============================================
  Files           380      380              
  Lines         11513    11516       +3     
  Branches       1450     1452       +2     
============================================
+ Hits          10324    10365      +41     
+ Misses          610      590      -20     
+ Partials        579      561      -18     
Impacted Files Coverage Δ Complexity Δ
...io/smallrye/mutiny/groups/UniAndGroupIterable.java 100.00% <100.00%> (ø) 9.00 <1.00> (+1.00)
...java/io/smallrye/mutiny/operators/AbstractUni.java 90.00% <0.00%> (-3.11%) 22.00% <0.00%> (ø%)
...va/io/smallrye/mutiny/operators/AbstractMulti.java 97.29% <0.00%> (-2.71%) 29.00% <0.00%> (ø%)
...erators/multi/builders/SerializedMultiEmitter.java 81.01% <0.00%> (-1.27%) 25.00% <0.00%> (-1.00%)
...entation/src/main/java/io/smallrye/mutiny/Uni.java 96.29% <0.00%> (ø) 22.00% <0.00%> (ø%)
...tation/src/main/java/io/smallrye/mutiny/Multi.java 100.00% <0.00%> (ø) 14.00% <0.00%> (ø%)
...lrye/mutiny/subscription/SerializedSubscriber.java 83.01% <0.00%> (+0.94%) 26.00% <0.00%> (+1.00%)
...smallrye/mutiny/operators/multi/MultiEmitOnOp.java 90.47% <0.00%> (+0.95%) 2.00% <0.00%> (ø%)
...operators/multi/processors/BroadcastProcessor.java 88.46% <0.00%> (+1.28%) 20.00% <0.00%> (ø%)
...y/operators/multi/processors/UnicastProcessor.java 97.34% <0.00%> (+1.76%) 45.00% <0.00%> (+1.00%)
... and 10 more

@jponge
Copy link
Member Author

jponge commented May 18, 2021

Dot not merge yet

@jponge
Copy link
Member Author

jponge commented May 19, 2021

Approved with user story

@jponge jponge merged commit d4e3cef into main May 19, 2021
@jponge jponge deleted the feature/uni-combineWith-cast branch May 19, 2021 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Thoughts on improving combine in Uni
2 participants