New approach for the awaitItems method in the AssertSubscriber #526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cescoffier
force-pushed
the
another-race-when-waiting-for-item
branch
2 times, most recently
from
75b02a8 to
7ebb002
Compare
The previous one has a race condition and so was missing events.
cescoffier
force-pushed
the
another-race-when-waiting-for-item
branch
from
7ebb002 to
02d8053
Compare
Codecov Report
@@ Coverage Diff @@
## main #526 +/- ##
=======================================
Coverage ? 90.05%
Complexity ? 3010
=======================================
Files ? 382
Lines ? 11619
Branches ? 1455
=======================================
Hits ? 10464
Misses ? 589
Partials ? 566
|
jponge
approved these changes
Apr 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous one has a race condition and so was missing events.