Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delay the start of the "ticks" after the first request. #514

Merged
merged 1 commit into from
Mar 30, 2021

Conversation

cescoffier
Copy link
Contributor

Delay the start of the ticks until we get the first initial request.

Related to smallrye/smallrye-reactive-messaging#1125.

@cescoffier cescoffier added the bug Something isn't working label Mar 25, 2021
@cescoffier cescoffier added this to the 0.15.0 milestone Mar 25, 2021
@cescoffier cescoffier requested a review from jponge March 25, 2021 12:21
@codecov
Copy link

codecov bot commented Mar 25, 2021

Codecov Report

Merging #514 (2fb69f7) into main (23a3c74) will increase coverage by 0.26%.
The diff coverage is 100.00%.

❗ Current head 2fb69f7 differs from pull request most recent head 60dced0. Consider uploading reports for the commit 60dced0 to get more accurate results
Impacted file tree graph

@@             Coverage Diff              @@
##               main     #514      +/-   ##
============================================
+ Coverage     89.91%   90.17%   +0.26%     
- Complexity     3002     3012      +10     
============================================
  Files           382      382              
  Lines         11597    11600       +3     
  Branches       1446     1449       +3     
============================================
+ Hits          10427    10460      +33     
+ Misses          594      578      -16     
+ Partials        576      562      -14     
Impacted Files Coverage Δ Complexity Δ
...in/java/io/smallrye/mutiny/groups/MultiCreate.java 100.00% <ø> (ø) 44.00 <0.00> (ø)
...smallrye/mutiny/helpers/test/AssertSubscriber.java 93.62% <ø> (ø) 75.00 <0.00> (ø)
...mutiny/operators/multi/builders/IntervalMulti.java 92.00% <100.00%> (+0.51%) 3.00 <0.00> (ø)
...mallrye/mutiny/operators/multi/MultiFlatMapOp.java 85.98% <0.00%> (+0.31%) 3.00% <0.00%> (ø%)
...a/io/smallrye/mutiny/helpers/BlockingIterable.java 89.79% <0.00%> (+1.02%) 10.00% <0.00%> (ø%)
...erators/multi/builders/SerializedMultiEmitter.java 82.27% <0.00%> (+1.26%) 26.00% <0.00%> (+1.00%)
...tiny/operators/multi/MultiBufferWithTimeoutOp.java 74.57% <0.00%> (+1.69%) 4.00% <0.00%> (ø%)
...java/io/smallrye/mutiny/helpers/Subscriptions.java 80.11% <0.00%> (+2.76%) 48.00% <0.00%> (+2.00%)
...mallrye/mutiny/operators/multi/FlatMapManager.java 98.61% <0.00%> (+2.77%) 20.00% <0.00%> (+1.00%)
...perators/multi/processors/SerializedProcessor.java 90.09% <0.00%> (+2.97%) 24.00% <0.00%> (+1.00%)
... and 4 more

Copy link
Member

@jponge jponge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Note that it becomes a hot stream after the first subscriber makes a request.

@cescoffier cescoffier force-pushed the delay-ticks-until-requests branch from 7844dea to 60dced0 Compare March 25, 2021 13:46
@cescoffier
Copy link
Contributor Author

Good point @jponge, I've extended the javadoc.

@cescoffier cescoffier merged commit 78851ba into main Mar 30, 2021
@cescoffier cescoffier deleted the delay-ticks-until-requests branch March 30, 2021 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants