Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow configuring a delay between two repetitions #498

Merged
merged 2 commits into from
Mar 11, 2021
Merged

Allow configuring a delay between two repetitions #498

merged 2 commits into from
Mar 11, 2021

Conversation

cescoffier
Copy link
Contributor

Fix #344

@cescoffier cescoffier requested a review from jponge March 10, 2021 13:58
@cescoffier cescoffier added this to the 0.15.0 milestone Mar 10, 2021
@cescoffier cescoffier added the enhancement New feature or request label Mar 10, 2021
@cescoffier cescoffier changed the title Allow configuring a delay between two repetitions. Allow configuring a delay between two repetitions Mar 10, 2021
@codecov
Copy link

codecov bot commented Mar 10, 2021

Codecov Report

Merging #498 (9b6d45a) into main (45eb8ee) will increase coverage by 0.09%.
The diff coverage is 87.11%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #498      +/-   ##
============================================
+ Coverage     90.00%   90.09%   +0.09%     
- Complexity     2927     3006      +79     
============================================
  Files           382      382              
  Lines         11340    11594     +254     
  Branches       1420     1447      +27     
============================================
+ Hits          10206    10446     +240     
- Misses          579      583       +4     
- Partials        555      565      +10     
Impacted Files Coverage Δ Complexity Δ
...e/mutiny/helpers/spies/MultiOnCancellationSpy.java 69.23% <33.33%> (-30.77%) 6.00 <2.00> (+2.00) ⬇️
.../smallrye/mutiny/helpers/test/AssertionHelper.java 73.39% <42.85%> (-4.16%) 48.00 <2.00> (+3.00) ⬇️
...n/java/io/smallrye/mutiny/groups/UniOnFailure.java 91.89% <50.00%> (-8.11%) 25.00 <1.00> (-1.00)
...rye/mutiny/operators/multi/MultiRepeatUntilOp.java 95.45% <75.00%> (-4.55%) 5.00 <0.00> (ø)
...llrye/mutiny/helpers/test/UniAssertSubscriber.java 91.85% <87.83%> (-5.83%) 54.00 <27.00> (+17.00) ⬇️
...smallrye/mutiny/helpers/test/AssertSubscriber.java 93.90% <93.06%> (-3.54%) 73.00 <48.00> (+43.00) ⬇️
...main/java/io/smallrye/mutiny/groups/UniRepeat.java 100.00% <100.00%> (ø) 7.00 <3.00> (+2.00)
...ye/mutiny/operators/multi/MultiRepeatWhilstOp.java 86.66% <100.00%> (+0.45%) 2.00 <0.00> (ø)
...mallrye/mutiny/operators/multi/MultiFlatMapOp.java 85.98% <0.00%> (-0.32%) 3.00% <0.00%> (ø%)
... and 6 more

@jponge
Copy link
Member

jponge commented Mar 11, 2021

@cescoffier see 8b0eadd

Copy link
Contributor Author

@cescoffier cescoffier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jponge jponge merged commit 30da80a into main Mar 11, 2021
@jponge jponge deleted the fix-344 branch March 11, 2021 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pagination should be able deal with throttled API
2 participants