Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uni signals tracking and ordering assertion in UniAssertSubscriber #464

Merged
merged 1 commit into from
Jan 29, 2021

Conversation

jponge
Copy link
Member

@jponge jponge commented Jan 29, 2021

This is useful to check if a Uni has received signals in correct order.

@jponge jponge added the enhancement New feature or request label Jan 29, 2021
@jponge jponge added this to the 0.14.0 milestone Jan 29, 2021
@jponge jponge requested a review from cescoffier January 29, 2021 17:53
@jponge jponge force-pushed the uniassert-signals-assertions branch from 3e5a63c to f96d8b0 Compare January 29, 2021 18:00
@codecov
Copy link

codecov bot commented Jan 29, 2021

Codecov Report

Merging #464 (485b109) into master (8f879c9) will increase coverage by 0.36%.
The diff coverage is 93.61%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #464      +/-   ##
============================================
+ Coverage     90.08%   90.45%   +0.36%     
- Complexity     2873     2912      +39     
============================================
  Files           374      378       +4     
  Lines         11001    11048      +47     
  Branches       1347     1359      +12     
============================================
+ Hits           9910     9993      +83     
+ Misses          555      536      -19     
+ Partials        536      519      -17     
Impacted Files Coverage Δ Complexity Δ
...e/mutiny/helpers/test/OnCancellationUniSignal.java 33.33% <33.33%> (ø) 1.00 <1.00> (?)
...lrye/mutiny/helpers/test/OnSubscribeUniSignal.java 80.00% <80.00%> (ø) 2.00 <2.00> (?)
...allrye/mutiny/helpers/test/OnFailureUniSignal.java 100.00% <100.00%> (ø) 3.00 <3.00> (?)
.../smallrye/mutiny/helpers/test/OnItemUniSignal.java 100.00% <100.00%> (ø) 3.00 <3.00> (?)
...llrye/mutiny/helpers/test/UniAssertSubscriber.java 97.67% <100.00%> (+1.18%) 37.00 <20.00> (+14.00)
...y/operators/multi/processors/UnicastProcessor.java 95.57% <0.00%> (-1.77%) 44.00% <0.00%> (-1.00%)
... and 11 more

@cescoffier cescoffier merged commit be7c7a8 into master Jan 29, 2021
@cescoffier cescoffier deleted the uniassert-signals-assertions branch January 29, 2021 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants