Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix repetition when the first emitted item is null #454

Merged
merged 1 commit into from
Jan 20, 2021
Merged

Conversation

cescoffier
Copy link
Contributor

Fix #447


@cescoffier cescoffier requested a review from jponge January 20, 2021 13:38
@cescoffier cescoffier added the bug Something isn't working label Jan 20, 2021
@cescoffier cescoffier added this to the 0.14.0 milestone Jan 20, 2021
@codecov
Copy link

codecov bot commented Jan 20, 2021

Codecov Report

Merging #454 (14c4e5e) into master (77b3c3a) will increase coverage by 0.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #454      +/-   ##
============================================
+ Coverage     90.11%   90.18%   +0.06%     
- Complexity     2777     2779       +2     
============================================
  Files           373      373              
  Lines         10668    10669       +1     
  Branches       1309     1311       +2     
============================================
+ Hits           9614     9622       +8     
  Misses          559      559              
+ Partials        495      488       -7     
Impacted Files Coverage Δ Complexity Δ
...main/java/io/smallrye/mutiny/groups/UniRepeat.java 100.00% <ø> (ø) 5.00 <0.00> (ø)
...rye/mutiny/operators/multi/MultiRepeatUntilOp.java 100.00% <100.00%> (ø) 5.00 <0.00> (ø)
.../io/smallrye/mutiny/helpers/queues/DrainUtils.java 86.66% <0.00%> (-8.89%) 13.00% <0.00%> (-3.00%)
...iny/operators/multi/builders/BaseMultiEmitter.java 83.33% <0.00%> (-4.17%) 20.00% <0.00%> (-1.00%)
...operators/multi/builders/CollectionBasedMulti.java 90.16% <0.00%> (-3.28%) 4.00% <0.00%> (ø%)
...erators/multi/builders/SerializedMultiEmitter.java 83.54% <0.00%> (-1.27%) 27.00% <0.00%> (+1.00%) ⬇️
...mallrye/mutiny/operators/multi/MultiFlatMapOp.java 86.91% <0.00%> (+0.62%) 3.00% <0.00%> (ø%)
...smallrye/mutiny/operators/multi/MultiEmitOnOp.java 90.47% <0.00%> (+0.95%) 2.00% <0.00%> (ø%)
...a/io/smallrye/mutiny/helpers/BlockingIterable.java 89.79% <0.00%> (+1.02%) 10.00% <0.00%> (ø%)
...erators/multi/builders/BufferItemMultiEmitter.java 90.00% <0.00%> (+1.42%) 25.00% <0.00%> (+1.00%)
... and 5 more

@jponge jponge merged commit 7d2a3e2 into master Jan 20, 2021
@jponge jponge deleted the fix-447 branch January 20, 2021 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multi.createBy().repeating().supplier() completes on empty (null) item
2 participants