Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup the operator classes package layout #452

Merged
merged 2 commits into from
Jan 22, 2021

Conversation

jponge
Copy link
Member

@jponge jponge commented Jan 19, 2021

No description provided.

@jponge
Copy link
Member Author

jponge commented Jan 19, 2021

@cescoffier here's a reworked layout, but it fails right now due to RevApi.

@jponge jponge force-pushed the internal/rework-operators-classes-layout branch from 073a674 to f0efbc0 Compare January 20, 2021 18:06
UniSerializedSubscriber is tied to AbstractUni#subscribing so it can't be moved right now.

Also RevApi doesn't seem to honor package exclusion, so it complains that classes have been removed.
@jponge jponge force-pushed the internal/rework-operators-classes-layout branch from f0efbc0 to 6f19948 Compare January 20, 2021 20:39
@codecov
Copy link

codecov bot commented Jan 21, 2021

Codecov Report

Merging #452 (f624a2b) into master (d41996d) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #452   +/-   ##
=========================================
  Coverage     90.15%   90.16%           
+ Complexity     2871     2870    -1     
=========================================
  Files           373      373           
  Lines         10952    10952           
  Branches       1344     1346    +2     
=========================================
+ Hits           9874     9875    +1     
  Misses          547      547           
+ Partials        531      530    -1     
Impacted Files Coverage Δ Complexity Δ
...java/io/smallrye/mutiny/groups/MultiBroadcast.java 100.00% <ø> (ø) 5.00 <0.00> (ø)
...n/java/io/smallrye/mutiny/groups/MultiIfEmpty.java 100.00% <ø> (ø) 20.00 <0.00> (ø)
...o/smallrye/mutiny/groups/MultiItemCombination.java 100.00% <ø> (ø) 10.00 <0.00> (ø)
...a/io/smallrye/mutiny/groups/MultiItemCombine2.java 100.00% <ø> (ø) 6.00 <0.00> (?)
...a/io/smallrye/mutiny/groups/MultiItemCombine3.java 100.00% <ø> (ø) 6.00 <0.00> (?)
...a/io/smallrye/mutiny/groups/MultiItemCombine4.java 100.00% <ø> (ø) 6.00 <0.00> (?)
...a/io/smallrye/mutiny/groups/MultiItemCombine5.java 83.33% <ø> (ø) 5.00 <0.00> (?)
...a/io/smallrye/mutiny/groups/MultiItemCombine6.java 84.61% <ø> (ø) 5.00 <0.00> (?)
...a/io/smallrye/mutiny/groups/MultiItemCombine7.java 84.61% <ø> (ø) 5.00 <0.00> (?)
...a/io/smallrye/mutiny/groups/MultiItemCombine8.java 84.61% <ø> (ø) 5.00 <0.00> (?)
... and 70 more

@jponge jponge marked this pull request as ready for review January 21, 2021 17:21
@jponge jponge requested a review from cescoffier January 21, 2021 17:21
@jponge
Copy link
Member Author

jponge commented Jan 21, 2021

I ended up adding the RevApi documentation for the changes. I did my best to dispatch classes where I think they'd make sense, but please look carefully 😉

@jponge jponge added the technical-debt Technical debt reduction label Jan 21, 2021
@jponge jponge added this to the 0.14.0 milestone Jan 21, 2021
@cescoffier cescoffier merged commit d96cb81 into master Jan 22, 2021
@cescoffier cescoffier deleted the internal/rework-operators-classes-layout branch January 22, 2021 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
technical-debt Technical debt reduction
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants