Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Uni subscription when interceptors are present #443

Merged
merged 1 commit into from
Jan 14, 2021

Conversation

jponge
Copy link
Member

@jponge jponge commented Jan 13, 2021

No description provided.

@jponge jponge added this to the 0.13.0 milestone Jan 13, 2021
@jponge jponge added the technical-debt Technical debt reduction label Jan 13, 2021
@jponge
Copy link
Member Author

jponge commented Jan 13, 2021

Technically subscribing with subscriber rather than actual should work because it's already a wrapped object, but still, it's actual that is correct.

@codecov
Copy link

codecov bot commented Jan 13, 2021

Codecov Report

Merging #443 (fbd1ec2) into master (07df718) will increase coverage by 0.38%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #443      +/-   ##
============================================
+ Coverage     89.81%   90.19%   +0.38%     
- Complexity     2764     2778      +14     
============================================
  Files           373      373              
  Lines         10668    10668              
  Branches       1309     1311       +2     
============================================
+ Hits           9581     9622      +41     
+ Misses          579      558      -21     
+ Partials        508      488      -20     
Impacted Files Coverage Δ Complexity Δ
...lrye/mutiny/operators/UniSerializedSubscriber.java 92.30% <100.00%> (ø) 15.00 <0.00> (ø)
...erators/multi/builders/SerializedMultiEmitter.java 81.01% <0.00%> (-1.27%) 25.00% <0.00%> (-1.00%)
...o/smallrye/mutiny/operators/UniAndCombination.java 84.88% <0.00%> (-1.17%) 4.00% <0.00%> (ø%)
...smallrye/mutiny/operators/multi/MultiEmitOnOp.java 90.47% <0.00%> (+0.95%) 2.00% <0.00%> (ø%)
...mallrye/mutiny/operators/multi/MultiFlatMapOp.java 85.98% <0.00%> (+1.55%) 3.00% <0.00%> (ø%)
...mallrye/mutiny/helpers/queues/MpscLinkedQueue.java 98.38% <0.00%> (+1.61%) 29.00% <0.00%> (+1.00%)
...java/io/smallrye/mutiny/helpers/Subscriptions.java 79.55% <0.00%> (+2.20%) 48.00% <0.00%> (+2.00%)
...rye/mutiny/converters/uni/UniToMultiPublisher.java 91.66% <0.00%> (+2.77%) 2.00% <0.00%> (ø%)
...iny/operators/multi/builders/BaseMultiEmitter.java 87.50% <0.00%> (+4.16%) 21.00% <0.00%> (+1.00%)
...y/operators/multi/builders/IterableBasedMulti.java 86.17% <0.00%> (+4.25%) 4.00% <0.00%> (ø%)
... and 5 more

Copy link
Contributor

@cescoffier cescoffier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@cescoffier cescoffier added bug Something isn't working and removed technical-debt Technical debt reduction labels Jan 14, 2021
@cescoffier cescoffier merged commit a24211b into master Jan 14, 2021
@cescoffier cescoffier deleted the fix-uni-directsubscription branch January 14, 2021 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants