Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Iteration optimisations regarding Infrastructure's interceptors #442

Merged
merged 1 commit into from
Jan 13, 2021

Conversation

Sanne
Copy link
Contributor

@Sanne Sanne commented Jan 13, 2021

Iteration optimisations for Infrastructure#MULTI_INTERCEPTORS and UNI_INTERCEPTORS

This optimises the iteration of MULTI_INTERCEPTORS and UNI_INTERCEPTORS , with a focus on object allocations.

Should not introduce any semantic changes.

@codecov
Copy link

codecov bot commented Jan 13, 2021

Codecov Report

Merging #442 (f7ad94d) into master (b1ea965) will increase coverage by 0.34%.
The diff coverage is 61.90%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #442      +/-   ##
============================================
+ Coverage     89.79%   90.13%   +0.34%     
- Complexity     2766     2776      +10     
============================================
  Files           373      373              
  Lines         10670    10668       -2     
  Branches       1309     1311       +2     
============================================
+ Hits           9581     9616      +35     
+ Misses          582      560      -22     
+ Partials        507      492      -15     
Impacted Files Coverage Δ Complexity Δ
...smallrye/mutiny/infrastructure/Infrastructure.java 69.00% <61.90%> (+1.35%) 23.00 <3.00> (-2.00) ⬆️
...java/io/smallrye/mutiny/helpers/Subscriptions.java 78.45% <0.00%> (-0.56%) 47.00% <0.00%> (ø%)
...mallrye/mutiny/operators/multi/MultiFlatMapOp.java 85.98% <0.00%> (+0.93%) 3.00% <0.00%> (ø%)
...smallrye/mutiny/operators/multi/MultiEmitOnOp.java 90.47% <0.00%> (+0.95%) 2.00% <0.00%> (ø%)
...y/operators/multi/builders/IterableBasedMulti.java 86.17% <0.00%> (+2.12%) 4.00% <0.00%> (ø%)
...erators/multi/builders/SerializedMultiEmitter.java 86.07% <0.00%> (+3.79%) 27.00% <0.00%> (+1.00%)
...iny/operators/multi/builders/BaseMultiEmitter.java 87.50% <0.00%> (+4.16%) 21.00% <0.00%> (+1.00%)
...lrye/mutiny/subscription/SerializedSubscriber.java 88.67% <0.00%> (+6.60%) 28.00% <0.00%> (+3.00%)
...mallrye/mutiny/helpers/queues/MpscLinkedQueue.java 98.38% <0.00%> (+8.06%) 29.00% <0.00%> (+2.00%)
... and 1 more

@cescoffier cescoffier requested a review from jponge January 13, 2021 16:03
@cescoffier cescoffier changed the title Iteration optimisations for Infrastructure#MULTI_INTERCEPTORS and UNI… Iteration optimisations regarding Infrastructure's interceptors Jan 13, 2021
@cescoffier cescoffier added this to the 0.13.0 milestone Jan 13, 2021
@cescoffier cescoffier added the enhancement New feature or request label Jan 13, 2021
@jponge
Copy link
Member

jponge commented Jan 13, 2021

Let's have it, codecov is broken here.

Thanks @Sanne!

@jponge jponge merged commit 07df718 into smallrye:master Jan 13, 2021
@Sanne Sanne deleted the Opt branch January 13, 2021 20:43
@Sanne
Copy link
Contributor Author

Sanne commented Jan 13, 2021

Thanks! And looking forward for the next release, all your optimisations are having an awesome impact

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants