Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename collectItems() and groupItems() into collect() and group() #413

Merged
merged 1 commit into from
Jan 4, 2021

Conversation

cescoffier
Copy link
Contributor

It follows the same names as the select() group from #408.

  • Deprecate previous methods and provide the new methods
  • Update tests, documentation, and pictures
    • Remove the MultiCollect intermediate class

…lowing the next to be select() method.

- Deprecate previous method and provide the new methods
- Update tests, documentation and pictures
@cescoffier cescoffier added the enhancement New feature or request label Jan 2, 2021
@cescoffier cescoffier added this to the 0.13.0 milestone Jan 2, 2021
@cescoffier cescoffier requested a review from jponge January 2, 2021 08:46
@codecov
Copy link

codecov bot commented Jan 2, 2021

Codecov Report

Merging #413 (86e7b76) into master (044957b) will increase coverage by 0.14%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #413      +/-   ##
============================================
+ Coverage     89.24%   89.38%   +0.14%     
+ Complexity     2715     2713       -2     
============================================
  Files           363      362       -1     
  Lines         10524    10518       -6     
  Branches       1306     1308       +2     
============================================
+ Hits           9392     9402      +10     
+ Misses          588      577      -11     
+ Partials        544      539       -5     
Impacted Files Coverage Δ Complexity Δ
...tation/src/main/java/io/smallrye/mutiny/Multi.java 94.44% <100.00%> (+0.69%) 16.00 <2.00> (+2.00)
...n/java/io/smallrye/mutiny/groups/MultiCollect.java 100.00% <100.00%> (ø) 12.00 <10.00> (+2.00)
...io/smallrye/mutiny/groups/MultiGroupIntoLists.java 100.00% <100.00%> (ø) 6.00 <5.00> (ø)
...va/io/smallrye/mutiny/operators/AbstractMulti.java 100.00% <100.00%> (ø) 24.00 <2.00> (ø)
...rye/mutiny/streams/stages/CollectStageFactory.java 100.00% <100.00%> (ø) 2.00 <0.00> (ø)
...e/mutiny/streams/stages/FindFirstStageFactory.java 100.00% <100.00%> (ø) 5.00 <0.00> (ø)
.../io/smallrye/mutiny/converters/multi/ToSingle.java 100.00% <100.00%> (ø) 3.00 <1.00> (ø)
...ye/mutiny/converters/multi/ToSingleFailOnNull.java 100.00% <100.00%> (ø) 2.00 <1.00> (ø)
...java/io/smallrye/mutiny/helpers/Subscriptions.java 80.11% <0.00%> (-1.11%) 48.00% <0.00%> (-1.00%)
...perators/multi/processors/SerializedProcessor.java 90.09% <0.00%> (ø) 24.00% <0.00%> (-1.00%)
... and 6 more

@jponge jponge merged commit 0df4b37 into master Jan 4, 2021
@jponge jponge deleted the rename-collect branch January 4, 2021 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants