Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Release Script #405

Merged
merged 7 commits into from
Jan 4, 2021
Merged

New Release Script #405

merged 7 commits into from
Jan 4, 2021

Conversation

cescoffier
Copy link
Contributor

@jponge
Copy link
Member

jponge commented Dec 18, 2020

Actually we can use Java 11 for JBang, we just need to switch JDK in the middle use the corresponding action as a step

@codecov
Copy link

codecov bot commented Dec 18, 2020

Codecov Report

Merging #405 (a92c3c3) into master (31b2580) will increase coverage by 0.37%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #405      +/-   ##
============================================
+ Coverage     89.09%   89.46%   +0.37%     
- Complexity     2711     2725      +14     
============================================
  Files           363      363              
  Lines         10524    10524              
  Branches       1306     1308       +2     
============================================
+ Hits           9376     9415      +39     
+ Misses          600      575      -25     
+ Partials        548      534      -14     
Impacted Files Coverage Δ Complexity Δ
...java/io/smallrye/mutiny/helpers/Subscriptions.java 79.00% <0.00%> (-1.11%) 47.00% <0.00%> (-1.00%)
...mallrye/mutiny/operators/multi/MultiFlatMapOp.java 85.09% <0.00%> (+0.62%) 3.00% <0.00%> (ø%)
...smallrye/mutiny/operators/multi/MultiEmitOnOp.java 90.47% <0.00%> (+0.95%) 2.00% <0.00%> (ø%)
...y/operators/multi/processors/UnicastProcessor.java 97.34% <0.00%> (+1.76%) 45.00% <0.00%> (+1.00%)
...y/operators/multi/builders/IterableBasedMulti.java 84.04% <0.00%> (+2.12%) 4.00% <0.00%> (ø%)
...mallrye/mutiny/operators/multi/FlatMapManager.java 95.83% <0.00%> (+2.77%) 19.00% <0.00%> (+1.00%)
.../io/smallrye/mutiny/helpers/queues/DrainUtils.java 95.55% <0.00%> (+8.88%) 15.00% <0.00%> (+1.00%)
...perators/multi/processors/SerializedProcessor.java 94.05% <0.00%> (+8.91%) 26.00% <0.00%> (+4.00%)
...erators/multi/builders/SerializedMultiEmitter.java 88.00% <0.00%> (+25.33%) 26.00% <0.00%> (+7.00%)

@cescoffier cescoffier force-pushed the new-release-script branch 3 times, most recently from 51abdd3 to 8b45e18 Compare December 23, 2020 10:10
* Switch from KScript to JBang
* Update deploy.sh
* Use Java 11 for the release build
The workflow runs the pre-checks, bump the version and push the tag.
This includes:

* post-release task (Github release, release notes...)
* website deployment
* deployment of the artifacts to Maven Central
env:
DRY_RUN: ${{ github.event.inputs.dry-run }}
BRANCH: ${{ github.event.inputs.branch }}
run: |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This and other similar run elements: shouldn't we offload the code to a proper shell script rather than some inline text in YAML?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can, we just need to be sure we keep the relation between the env variable and the script consistent.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, some parts are os specifics, which mean that even in a script - we won't be able to run them on our dev machine.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's keep it this way then

@jponge jponge merged commit 0ab0835 into master Jan 4, 2021
@jponge jponge deleted the new-release-script branch January 4, 2021 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants