-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Release Script #405
New Release Script #405
Conversation
cescoffier
commented
Dec 18, 2020
- Started working on Cleanup the CI/CD #404
- Make sure the output classes are using Java 8 bytecode
Actually we can use Java 11 for JBang, we just need to switch JDK in the middle use the corresponding action as a step |
5d49398
to
fac548c
Compare
Codecov Report
@@ Coverage Diff @@
## master #405 +/- ##
============================================
+ Coverage 89.09% 89.46% +0.37%
- Complexity 2711 2725 +14
============================================
Files 363 363
Lines 10524 10524
Branches 1306 1308 +2
============================================
+ Hits 9376 9415 +39
+ Misses 600 575 -25
+ Partials 548 534 -14
|
51abdd3
to
8b45e18
Compare
* Switch from KScript to JBang * Update deploy.sh * Use Java 11 for the release build
The workflow runs the pre-checks, bump the version and push the tag.
Yeah, the wonderful of modules...
This includes: * post-release task (Github release, release notes...) * website deployment * deployment of the artifacts to Maven Central
8b45e18
to
a92c3c3
Compare
env: | ||
DRY_RUN: ${{ github.event.inputs.dry-run }} | ||
BRANCH: ${{ github.event.inputs.branch }} | ||
run: | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This and other similar run
elements: shouldn't we offload the code to a proper shell script rather than some inline text in YAML?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can, we just need to be sure we keep the relation between the env variable and the script consistent.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, some parts are os specifics, which mean that even in a script - we won't be able to run them on our dev machine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's keep it this way then