Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix potential deadlock in the SwitchableSubscriptionSubscriber #386

Merged
merged 1 commit into from
Dec 9, 2020

Conversation

cescoffier
Copy link
Contributor

@cescoffier cescoffier commented Dec 9, 2020

@jponge That fixes the issue you reported with UniRepeat.

@cescoffier cescoffier requested a review from jponge December 9, 2020 14:08
@codecov
Copy link

codecov bot commented Dec 9, 2020

Codecov Report

Merging #386 (c239562) into master (6697375) will increase coverage by 0.33%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #386      +/-   ##
============================================
+ Coverage     89.21%   89.54%   +0.33%     
- Complexity     2710     2727      +17     
============================================
  Files           361      363       +2     
  Lines         10501    10520      +19     
  Branches       1302     1306       +4     
============================================
+ Hits           9368     9420      +52     
+ Misses          588      571      -17     
+ Partials        545      529      -16     
Impacted Files Coverage Δ Complexity Δ
...subscription/SwitchableSubscriptionSubscriber.java 97.54% <100.00%> (+2.45%) 46.00 <0.00> (+1.00)
...main/java/io/smallrye/mutiny/groups/UniCreate.java 100.00% <0.00%> (ø) 36.00% <0.00%> (-3.00%)
...ny/operators/uni/builders/StateSuppliedtemUni.java 92.30% <0.00%> (ø) 5.00% <0.00%> (?%)
.../mutiny/operators/uni/builders/SuppliedtemUni.java 100.00% <0.00%> (ø) 2.00% <0.00%> (?%)
...mallrye/mutiny/operators/multi/MultiFlatMapOp.java 86.64% <0.00%> (+0.93%) 3.00% <0.00%> (ø%)
...erators/multi/builders/SerializedMultiEmitter.java 88.00% <0.00%> (+1.33%) 26.00% <0.00%> (+1.00%)
...java/io/smallrye/mutiny/helpers/Subscriptions.java 81.21% <0.00%> (+2.76%) 49.00% <0.00%> (+2.00%)
...o/smallrye/mutiny/operators/DefaultUniEmitter.java 89.28% <0.00%> (+3.57%) 11.00% <0.00%> (+1.00%)
...lrye/mutiny/subscription/SerializedSubscriber.java 91.50% <0.00%> (+3.77%) 30.00% <0.00%> (+3.00%)
... and 4 more

@cescoffier cescoffier added this to the 0.12.0 milestone Dec 9, 2020
@cescoffier cescoffier added the bug Something isn't working label Dec 9, 2020
Copy link
Member

@jponge jponge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @cescoffier

@jponge jponge merged commit 25cee76 into master Dec 9, 2020
@jponge jponge deleted the repeat-deadlock branch December 9, 2020 14:59
@jponge jponge modified the milestones: 0.12.0, 0.12.1, 0.12.2, 0.12.3, 0.12.4, 0.12.5 Dec 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants