Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move test subscribers to the public API #352

Merged
merged 5 commits into from
Nov 16, 2020
Merged

Move test subscribers to the public API #352

merged 5 commits into from
Nov 16, 2020

Conversation

jponge
Copy link
Member

@jponge jponge commented Nov 15, 2020

No description provided.

@jponge
Move test subscribers to io.smallrye.mutiny.test in the public API
ad80db1 
AssertSubscriber and AbstractSubscriber have been moved from the test-utils module.
Moving all classes to that module would have created a cyclic dependency, so grouping
them in the main module made more sense.

Now test-utils only contains a mock utility class.

Also AssertSubscriber has been made AssertJ-free to ensure the main Mutiny module does
not bring a test dependency.
@jponge
Copy link
Member Author

jponge commented Nov 15, 2020 •
edited
Loading

Todo:

  • Javadocs
  • Documentation examples for AssertSubscriber and UniAssertSubscriber

@jponge jponge added the enhancement New feature or request label Nov 15, 2020
@jponge jponge added this to the 0.11.0 milestone Nov 15, 2020
@jponge jponge self-assigned this Nov 15, 2020
@codecov
Copy link

codecov bot commented Nov 15, 2020 •
edited
Loading

Codecov Report

Merging #352 (857990e) into master (bd1e92a) will decrease coverage by 0.34%.
The diff coverage is 6.89%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #352      +/-   ##
============================================
- Coverage     89.66%   89.32%   -0.35%     
- Complexity     2676     2715      +39     
============================================
  Files           359      360       +1     
  Lines         10306    10423     +117     
  Branches       1273     1291      +18     
============================================
+ Hits           9241     9310      +69     
- Misses          553      583      +30     
- Partials        512      530      +18
Impacted Files Coverage Δ Complexity Δ
...allrye/mutiny/helpers/test/AbstractSubscriber.java 96.00% <ø> (ø) 11.00 <0.00> (?)
...llrye/mutiny/helpers/test/UniAssertSubscriber.java 57.30% <ø> (ø) 25.00 <0.00> (?)
...smallrye/mutiny/helpers/test/AssertSubscriber.java 74.38% <3.57%> (ø) 40.00 <9.00> (?)
...rators/multi/overflow/MultiOnOverflowBufferOp.java 90.90% <100.00%> (ø) 2.00 <0.00> (ø)
...lrye/mutiny/subscription/SerializedSubscriber.java 88.67% <0.00%> (-1.89%) 28.00% <0.00%> (-1.00%)
...a/io/smallrye/mutiny/converters/multi/ToMaybe.java 100.00% <0.00%> (ø) 4.00% <0.00%> (ø%)
...rye/mutiny/operators/multi/MultiRepeatUntilOp.java 100.00% <0.00%> (ø) 5.00% <0.00%> (ø%)
...e/mutiny/streams/stages/FindFirstStageFactory.java 100.00% <0.00%> (ø) 5.00% <0.00%> (ø%)
... and 13 more

@cescoffier
Copy link
Contributor

Nice!

@jponge
Copy link
Member Author

jponge commented Nov 16, 2020

@codecov Do you support commands?

@jponge jponge requested a review from cescoffier November 16, 2020 15:48
@jponge jponge marked this pull request as ready for review November 16, 2020 15:48
@jponge
Copy link
Member Author

jponge commented Nov 16, 2020

Note that classes have moved packages, but since these were not really public APIs this should be fine.

@jponge jponge changed the title Move test subscribers to io.smallrye.mutiny.test in the public API Move test subscribers to the public API Nov 16, 2020
@jponge jponge merged commit 5d640ee into master Nov 16, 2020
@jponge jponge deleted the improvement/test-subscribers-as-public-api branch November 16, 2020 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cescoffier cescoffier cescoffier approved these changes

Assignees

@jponge jponge

Labels
enhancement New feature or request
Projects
None yet
Milestone
0.11.0
Development

Successfully merging this pull request may close these issues.
2 participants
@jponge @cescoffier