Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add a workshop example for Multi::split #1370

Merged
merged 1 commit into from
Sep 17, 2023
Merged

docs: add a workshop example for Multi::split #1370

merged 1 commit into from
Sep 17, 2023

Conversation

jponge
Copy link
Member

@jponge jponge commented Sep 15, 2023

Fixes #1368

@jponge jponge added the documentation Improvements or additions to documentation label Sep 15, 2023
@jponge jponge added this to the 2.5.0 milestone Sep 15, 2023
@jponge jponge requested a review from cescoffier September 15, 2023 16:11
@codecov
Copy link

codecov bot commented Sep 15, 2023 •
edited
Loading

Codecov Report

Merging #1370 (71c7c11) into main (dffea98) will decrease coverage by 0.05%.
Report is 1 commits behind head on main.
The diff coverage is n/a.

❗ Current head 71c7c11 differs from pull request most recent head abf3ba3. Consider uploading reports for the commit abf3ba3 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1370      +/-   ##
============================================
- Coverage     89.25%   89.20%   -0.05%     
+ Complexity     3359     3358       -1     
============================================
  Files           459      459              
  Lines         13438    13438              
  Branches       1655     1655              
============================================
- Hits          11994    11988       -6     
- Misses          801      806       +5     
- Partials        643      644       +1

see 9 files with indirect coverage changes

cescoffier
cescoffier approved these changes Sep 16, 2023
View reviewed changes
workshop-examples/src/main/java/_07_advanced_streaming/_01_Multi_Split.java
@@ -0,0 +1,80 @@
///usr/bin/env jbang "$0" "$@" ; exit $?
//DEPS io.smallrye.reactive:mutiny:2.4.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering how you plan to keep this version in sync?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With my fullstack shell script developer certification: https://github.com/smallrye/smallrye-mutiny/blob/main/.build/update-workshop-target-version.sh

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(and the WIP CI branch has been rebased to call it: jponge@7511a87)

@jponge jponge merged commit ae6e097 into main Sep 17, 2023
5 checks passed
@jponge jponge deleted the docs/split-in-workshop branch September 17, 2023 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cescoffier cescoffier cescoffier approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
2.5.0
Development

Successfully merging this pull request may close these issues.

Add a split operator workshop example
2 participants
@jponge @cescoffier