Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure Uni.eventually() also handles cancellation signals #1182

Merged
merged 1 commit into from
Jan 6, 2023
Merged

Conversation

jponge
Copy link
Member

@jponge jponge commented Jan 5, 2023

@jponge jponge added the bug Something isn't working label Jan 5, 2023
@jponge jponge added this to the 2.0.1 milestone Jan 5, 2023
@jponge jponge requested a review from cescoffier January 5, 2023 17:32
@codecov
Copy link

codecov bot commented Jan 5, 2023

Codecov Report

Merging #1182 (daa580e) into main (1f8a8e3) will increase coverage by 0.13%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1182      +/-   ##
============================================
+ Coverage     89.54%   89.68%   +0.13%     
- Complexity     3342     3346       +4     
============================================
  Files           458      458              
  Lines         13227    13227              
  Branches       1646     1646              
============================================
+ Hits          11844    11862      +18     
+ Misses          722      707      -15     
+ Partials        661      658       -3     
Impacted Files Coverage Δ
...entation/src/main/java/io/smallrye/mutiny/Uni.java 90.90% <100.00%> (ø)
...perators/multi/processors/SerializedProcessor.java 82.17% <0.00%> (-10.90%) ⬇️
...mallrye/mutiny/operators/multi/FlatMapManager.java 95.83% <0.00%> (-2.78%) ⬇️
...mallrye/mutiny/helpers/queues/MpscLinkedQueue.java 96.77% <0.00%> (-1.62%) ⬇️
...smallrye/mutiny/helpers/test/AssertSubscriber.java 90.90% <0.00%> (-1.52%) ⬇️
...tiny/operators/multi/MultiBufferWithTimeoutOp.java 73.94% <0.00%> (-0.85%) ⬇️
...mallrye/mutiny/operators/multi/MultiFlatMapOp.java 89.36% <0.00%> (+0.99%) ⬆️
...java/io/smallrye/mutiny/helpers/Subscriptions.java 81.76% <0.00%> (+1.10%) ⬆️
...ny/operators/uni/builders/UniCreateFromFuture.java 91.80% <0.00%> (+1.63%) ⬆️
...io/smallrye/mutiny/operators/uni/UniMemoizeOp.java 93.20% <0.00%> (+1.94%) ⬆️
... and 4 more

@cescoffier
Copy link
Contributor

It should be considered as a breaking change.

@jponge
Copy link
Member Author

jponge commented Jan 6, 2023

I don't think so, the API is stable, just we handle one extra signal but since we marketed it as a finally it's more a bug IMHO

@gavinking
Copy link

Personally I think it's more of an un-breaking change :-)

@jponge jponge merged commit 1b4d38c into main Jan 6, 2023
@jponge jponge deleted the fix/1181 branch January 6, 2023 12:45
@jponge jponge modified the milestones: 2.0.1, 2.1.0 Jan 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Uni.eventually shall handle cancellation
3 participants