Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New demand capping operator shall accumulate demand and not just cap it #886

Closed
jponge opened this issue Mar 22, 2022 · 0 comments · Fixed by #887
Closed

New demand capping operator shall accumulate demand and not just cap it #886

jponge opened this issue Mar 22, 2022 · 0 comments · Fixed by #887
Assignees
@jponge
Labels
enhancement New feature or request
Milestone
1.5.0

Comments

@jponge
Copy link
Member

jponge commented Mar 22, 2022

The initial implementation caps, but it should accumulate demand requests and cap the outstanding demand to be RS-compliant.
@jponge jponge added the enhancement New feature or request label Mar 22, 2022
@jponge jponge added this to the 1.5.0 milestone Mar 22, 2022
@jponge jponge self-assigned this Mar 22, 2022
jponge added a commit that referenced this issue Mar 23, 2022
@jponge
Fix the capping operators outstanding demand management
85895ac 
Although not apparent in the TCK tests, not tracking the outstanding demand is against the RS semantics.

This changes the capping evaluation from that of the triggering (subscription) request to evaluating the outstanding demand.

Fixes #886
@jponge jponge mentioned this issue Mar 23, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jponge jponge

Labels
enhancement New feature or request
Projects
None yet
Milestone
1.5.0
Development

Successfully merging a pull request may close this issue.

Fix the capping operators outstanding demand management smallrye/smallrye-mutiny
1 participant
@jponge