Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export less packages in module-info or open them all #739

Closed
jponge opened this issue Oct 29, 2021 · 0 comments · Fixed by #773
Closed

Export less packages in module-info or open them all #739

jponge opened this issue Oct 29, 2021 · 0 comments · Fixed by #773
Labels
enhancement New feature or request noteworthy-feature Noteworthy feature
Milestone
1.3.0

Comments

@jponge
Copy link
Member

jponge commented Oct 29, 2021

The current module-info exports lots of packages, including some that shall be considered as internal (e.g., io.smallrye.mutiny.operators.**, io.smallrye.mutiny.helpers.queues).

We shall review and carefully export only those packages that have classes that we consider part of the public / user facing API.
@jponge jponge added the enhancement New feature or request label Oct 29, 2021
@jponge jponge added this to the 1.2.0 milestone Oct 29, 2021
@jponge jponge modified the milestones: 1.2.0, 1.3.0 Nov 18, 2021
@jponge jponge changed the title Export less packages in module-info Export less packages in module-info or open them all Dec 7, 2021
jponge added a commit that referenced this issue Dec 7, 2021
@jponge
Rework the module-info declarations to be fully open modules
da417a2 
There is little benefit from strong encapsulation at this stage.

Fixes #739
@jponge jponge mentioned this issue Dec 7, 2021
Merged
@jponge jponge added the noteworthy-feature Noteworthy feature label Jan 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request noteworthy-feature Noteworthy feature
Projects
None yet
Milestone
1.3.0
Development

Successfully merging a pull request may close this issue.

Rework the module-info declarations to be fully open modules smallrye/smallrye-mutiny
1 participant
@jponge