Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix error parsing in dynamic client #920

Merged
merged 2 commits into from
Jul 20, 2021
Merged

Fix error parsing in dynamic client #920

merged 2 commits into from
Jul 20, 2021

Conversation

jmartisk
Copy link
Member

And allow to read other fields beyond code, message, path and extensions.

Fixes #919

phillip-kruger
phillip-kruger approved these changes Jul 20, 2021
View reviewed changes
Copy link
Member

@phillip-kruger phillip-kruger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At some point we should start replacing JsonP with Jackson (in our implementation)

@phillip-kruger phillip-kruger added this to the 1.2.9 milestone Jul 20, 2021
@phillip-kruger phillip-kruger merged commit d20b9a2 into smallrye:main Jul 20, 2021
@jmartisk jmartisk deleted the main-issue-919 branch July 20, 2021 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phillip-kruger phillip-kruger phillip-kruger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.3.0
Development

Successfully merging this pull request may close these issues.

Dynamic client does not parse errors from the server correctly
2 participants
@jmartisk @phillip-kruger