Allow running with Micrometer metrics #688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmartisk
force-pushed
the
main-issue-384
branch
from
a9ab369 to
91d3205
Compare
phillip-kruger
approved these changes
Mar 18, 2021
|
Thanks @jmartisk !! |
|
Are you backporting to 1.0.x ? |
I don't think it's necessary. Quarkus will be upgrading to MicroProfile 4 soon (and therefore SmallRye GraphQL 1.1), and strictly speaking this would be a breaking change for users who use the Micrometer Quarkus extension - because before this PR, metrics go through the Micrometer-MPMetrics bridge; and after this PR, they would be handled by micrometer directly, so there would be minor differences in behavior. |
|
Cool! Thanks ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
replacement for #673 but this should be less intrusive and shouldn't need any changes on runtime sides
The
MetricsServicenow automatically detects whether there is the Micrometer or MP Metrics API available and uses one of them (Micrometer is preferred).Fixes #384