fix #624: typesafe client: @Name annotation on methods, too
#682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...ntation/src/main/java/io/smallrye/graphql/client/typesafe/impl/reflection/ParameterInfo.java
Outdated
Show resolved
Hide resolved
|
@t1 As discussed - waiting on you to decide how to proceed. Let me know . |
… (and `@JsonbProperty`) Signed-off-by: Rüdiger zu Dohna <[email protected]>
t1
force-pushed
the
624-name-annotation-on-method
branch
from
f8d68c3 to
c312b5c
Compare
… JSON-B annotations (until when we use Jandex to have only a soft dependency)
|
I've removed the dependency on |
phillip-kruger
requested changes
Mar 19, 2021
phillip-kruger
requested changes
Mar 19, 2021
|
I am planning a 1.0.x release soon, do you want this in there too ? |
|
No, we're on 1.1 already. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(but not
@JsonbProperty, yet)Signed-off-by: Rüdiger zu Dohna [email protected]