Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert metrics to dimensional #383

Merged
merged 1 commit into from
Aug 31, 2020
Merged

Convert metrics to dimensional #383

merged 1 commit into from
Aug 31, 2020

Conversation

jmartisk
Copy link
Member

Fixes #361

@jmartisk jmartisk requested review from t1 and phillip-kruger August 31, 2020 06:42
@jmartisk
Copy link
Member Author

Of course, ignore the failing WildFly tests, this will need corresponding changes in WildFly :)

phillip-kruger
phillip-kruger approved these changes Aug 31, 2020
View reviewed changes
Copy link
Member

@phillip-kruger phillip-kruger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jmartisk !!

@phillip-kruger phillip-kruger added this to the 1.0.9 milestone Aug 31, 2020
@phillip-kruger phillip-kruger merged commit 475845b into smallrye:master Aug 31, 2020
@jmartisk jmartisk deleted the master-issue-361 branch August 31, 2020 07:31
@jmartisk jmartisk mentioned this pull request Aug 31, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phillip-kruger phillip-kruger phillip-kruger approved these changes

@t1 t1 Awaiting requested review from t1

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0.9
Development

Successfully merging this pull request may close these issues.

Convert metrics to dimensional
2 participants
@jmartisk @phillip-kruger