-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support JDK9 methods using MR-JAR #98
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not too sure how to test this though.
Hmm, not sure either. We would need some special settings for surefire plugin that only adds certain test sources with JDK 9+?
@manovotn I've updated the way I do the MR to the first option recommended on https://maven.apache.org/plugins/maven-compiler-plugin/multirelease.html which means we have two virtual modules:
and It's more standard build for Maven I guess, but it has two drawbacks:
I added tests for the new methods too. |
Updated it again with the structure supported by smallrye-parent, that's much cleaner. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am probably missing something but why do you need empty files such as core/build-release-8
or tests/build-release-8
?
Otherwise looks pretty good.
I think this PR's CI is toast, lemme reopen one. |
Same CI issue so let's keep this one open. |
Finally, CI rules are fixed. |
Have a look at the docs here: https://github.com/smallrye/smallrye-parent/blob/master/README.adoc |
WDYT @manovotn ? I'm not too sure how to test this though. I have to check how other projects do it in the CI.