Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added path information to failing class level validations #938

Merged
merged 3 commits into from
May 25, 2023
Merged

Added path information to failing class level validations #938

merged 3 commits into from
May 25, 2023

Conversation

BenjaminTanguay
Copy link
Contributor

@BenjaminTanguay BenjaminTanguay commented May 18, 2023 •
edited by radcortez
Loading

Fixes #935

@BenjaminTanguay BenjaminTanguay mentioned this pull request May 18, 2023
Closed
@radcortez
Copy link
Member

Thank you for the PR. I've left some comments.

Also, CI is not happy.

@BenjaminTanguay
Post-review changes
bca47e0 
- Path elements are separated by a '.'
- Constraints are imported individually
@BenjaminTanguay
Reverted separation of path information and violationPath by a space …
2f50f18 
…instead of a dot.
@radcortez radcortez merged commit 25b7045 into smallrye:main May 25, 2023
@radcortez
Copy link
Member

Thanks for the PR. Appreciated!

@radcortez radcortez added this to the 3.2.2 milestone May 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manofthepeace manofthepeace manofthepeace left review comments

@radcortez radcortez radcortez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.3.0
Development

Successfully merging this pull request may close these issues.

Class level validations on configuration don't report the path of the failing property element
3 participants
@BenjaminTanguay @radcortez @manofthepeace