Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NPE when obtaining ConfigValue via getValue #907

Merged
merged 1 commit into from
Mar 16, 2023

Conversation

mabartos
Copy link
Contributor

Fixes #906

@mabartos mabartos changed the title NPE when obtaining ConfigValue via getValue NPE when obtaining ConfigValue via getValue Mar 14, 2023
Copy link
Member

@radcortez radcortez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @mabartos,

Thank you for the PR. Can you also provide the test case that causes the issue, please? Thank you!

@mabartos
Copy link
Contributor Author

@radcortez Yep, tests were added, and I think the test coverage of the issue is sufficient.

It solves a problem when there are multiple ConfigSourceInterceptors and ExpressionConfigSourceInterceptor is not able to handle null values.

@radcortez radcortez added this to the 3.2.0 milestone Mar 16, 2023
@radcortez
Copy link
Member

Great. Thank you!

@radcortez radcortez merged commit 9184830 into smallrye:main Mar 16, 2023
@mabartos
Copy link
Contributor Author

@radcortez Hi, do you have any ETA for the 3.2.0 release?

@radcortez
Copy link
Member

The current plan is to release it this week. Currently working in integrating some of the new features in Quarkus.

@mabartos
Copy link
Contributor Author

@radcortez Ok, thanks for the info.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NPE when obtaining ConfigValue via getValue
2 participants