Use AdoptOpenJDK's Java setup #40
Conversation
This allows us to have a consistent & functional env var for the JDK installation.
|
Hum, maybe you want to use the one from @cescoffier :) https://github.com/marketplace/actions/setup-java-using-binaries-from-adoptopenjdk |
|
Nope, you want the one provided by adoptOpenJdk.
…On Thu 16 Jul 2020 at 17:55, Roberto Cortez ***@***.***> wrote:
Hum, maybe you want to use the one from @cescoffier
<https://github.com/cescoffier> :)
https://github.com/marketplace/actions/setup-java-using-binaries-from-adoptopenjdk
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#40 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AADCG7OSI3JUTSRVXDYLR63R34PGJANCNFSM4O4PJVQA>
.
|
|
We need to be able to specify an env var for the JDK release, and setup-java and most of its derivatives don't support that (or don't support it well or correctly). |
|
I proposed fix for the Jacoco problem in smallrye/smallrye-parent#148. |
|
@dmlloyd you can use a matrix as I did for mutiny: |
|
Lets fix Parent, release and fix this one. |
In this case we explicitly do not want a matrix. The POM already knows how to test with each JDK, and using a matrix will dramatically increase the amount of time it takes to build the project; anyway, to properly use the SmallRye MR JAR support, the POM must only be run by the latest supported JDK. |
|
I guess then this is waiting for smallrye/smallrye-parent#149 to get merged so we can do a release of that project, bump up the version here, and get a green board for merging. |
|
Kudos, SonarCloud Quality Gate passed!
|
This allows us to have a consistent & functional env var for the JDK installation.