Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: resending messages while clicking error callout #340

Open
wants to merge 3 commits into
base: alpha
Choose a base branch
from

Conversation

alashchev17
Copy link
Collaborator

@alashchev17 alashchev17 commented Feb 11, 2025

Fix: resending messages while clicking error callout

Description

  • Provides retry for all messages in the chat if user clicks Click to retry in error callout, if messages are not empty array and if state.chat.error contains the error message (so in that case we can say, that this error is from the chat itself, not from somewhere else in the app)
  • Note: Tested with erroring integration config files. If error is permanent, then this retry will not get rid of error. This fix will give the simplification of user flow by minimizing amount of steps to get chat working after error message has appeared.
  • Bug - When press "Click to retry" last message is deleted and last but one message is re-requested

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (no functional changes, only code improvements)
  • Documentation update

Checklist

  • My code follows the code style of this project.
  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • Any dependent changes have been merged and published in downstream modules.
  • I have updated the documentation where necessary.

@alashchev17 alashchev17 self-assigned this Feb 11, 2025
…trying to send messages, if messages array is empty
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants