Add test #47
Merged
Add test #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
README.md
Outdated
| make prepare | ||
| make prepare # generate all missing files | ||
| make prepare-keys # generate only SSH credentials | ||
| make prepare-data # generate only Kitodo OCR scripts |
There was a problem hiding this comment.
Suggested change
| make prepare-data # generate only Kitodo OCR scripts | |
| make prepare-data # generate data which are required for all profiles | |
There was a problem hiding this comment.
why all profiles? It's only Kitodo, isn't it? Also, it's just the scripts I thought...
There was a problem hiding this comment.
Yes. Atm there are just the scripts but it is conceivable that further Kitodo files and folders will be added or service folders. We can change if its necessary.
README.md
Outdated
| make prepare # generate all missing files | ||
| make prepare-keys # generate only SSH credentials | ||
| make prepare-data # generate only Kitodo OCR scripts | ||
| make prepare-examples # generate only Kitodo DB entries |
There was a problem hiding this comment.
Suggested change
| make prepare-examples # generate only Kitodo DB entries | |
| make prepare-examples # generate example data for Kitodo.Production for example DB entries and process |
There was a problem hiding this comment.
we already have examples in the name of the target – no need to repeat twice. (Also, the explanation above already enumerates which things are added to the database.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.