Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): update npm dev (major) #753

Merged
merged 8 commits into from
Apr 3, 2024
Merged

chore(deps): update npm dev (major) #753

merged 8 commits into from
Apr 3, 2024

Conversation

ramonpetgrave64
Copy link
Contributor

@ramonpetgrave64 ramonpetgrave64 commented Apr 2, 2024 •
edited
Loading

Redo of #654

  • Fix dev-dependencies related to es-lint that the renovate-bot couldn't auto-fix

  • a few commas automatically added by the new linter

  • use node20 for tests to avoid caompatibility warnings

npm WARN EBADENGINE Unsupported engine {
npm WARN EBADENGINE   package: '@typescript-eslint/[email protected]',
npm WARN EBADENGINE   required: { node: '^18.18.0 || >=20.0.0' },
npm WARN EBADENGINE   current: { node: 'v16.20.2', npm: '8.19.4' }
npm WARN EBADENGINE }

renovate-bot and others added 7 commits April 2, 2024 19:19
@ramonpetgrave64 ramonpetgrave64 marked this pull request as ready for review April 2, 2024 19:33
@ramonpetgrave64
Copy link
Contributor Author

@laurentsimon

laurentsimon
laurentsimon approved these changes Apr 3, 2024
View reviewed changes
Copy link
Contributor

@laurentsimon laurentsimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@laurentsimon laurentsimon merged commit bcc39bf into slsa-framework:main Apr 3, 2024
15 checks passed
@ramonpetgrave64 ramonpetgrave64 mentioned this pull request Apr 3, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laurentsimon laurentsimon laurentsimon approved these changes

@kpk47 kpk47 Awaiting requested review from kpk47

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ramonpetgrave64 @laurentsimon @renovate-bot