java maven hint

slow-groovin · Aug 15, 2024 · 9fba350 · 9fba350
1 parent 345bfef
commit 9fba350
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/.github/workflows/docker-image-build-push-spring.yml b/.github/workflows/docker-image-build-push-spring.yml
@@ -25,7 +25,7 @@ jobs:
         with:
           java-version: '21'
           distribution: 'liberica'
-          server-password: MY_GH_SECRET_TOKEN
+#          server-password: MY_GH_SECRET_TOKEN #with test, this will not work for when maven project has a dependency of same/other github repo's packages
           cache: maven
       - name: run echo something
         run: |
@@ -40,8 +40,8 @@ jobs:
 
       - name: Build with Maven
         run: cd java && mvn -B package -P github -X
-#        env:
-#          GITHUB_TOKEN: ${{ secrets.MY_GH_SECRET_TOKEN }}
+        env:
+          GITHUB_TOKEN: ${{ secrets.MY_GH_SECRET_TOKEN }}  # only this will not work for when maven project has a dependency of same/other github repo's packages
 
       - name: Set up Docker Buildx
         uses: docker/setup-buildx-action@v3