-
-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Example] Botton navigation with Riverpod #601
[Example] Botton navigation with Riverpod #601
Conversation
Hey @vduseev! 👋 This example looks great at a first glance. |
Hi @slovnicki, glad too hear that! Let me know if you think there is a room for improvement. I was mostly concerned about the need to use a constructor in a state object to pass initialization parameters to the nested router delegates. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vduseev, Thanks again for this amazingly documented example.
Everything works as described 👌
I thought we could separate the code into more files for readability, but then again - we don't do that in other similar examples, so let's just stay structurally unbiased on this one too.
I don't see a problem in constructor usage you mentioned, but maybe we figure something more convenient in the future. Your idea of storing initial paths sounds really useful and I'm interested in adding some optional storage strategies into Beamer itself. If defined on the root Beamer, then its children could read/write from there even implicitly.
Are you interested in helping me out on that feature?
@slovnicki, Thank you very much for accepting the PR. The use of constructors in a State object is something I've considered to be a bad practice, simply based on a general sentiment across the flutter industry. Which is why I've tried to avoid doing that, but, unfortunately, couldn't find a way around. I'd be really happy to assist in implementation of the idea of storing persistent locations using Beamer. If you could, maybe, lay down your creative approach to this vision in a separate issue, so that all contributors could understand the concept better, that would be awesome. |
@vduseev Thanks for the kind words and interest in contributing. I plan to publish a somewhat lengthy roadmap to Beamer v2 where I'll describe a couple of new big features in separate issues and various improvements I have in mind. Something always gets in my way so this roadmap has been postponed for some time now, but I feel confident to publish it by the end of this week. (edit: it will be done by 7.4. and officially announced on 10.4.) I'll let you know when it's out 🙂 |
Thank you @vduseev for your example, I was really looking for this ! |
New example that implements bottom navigation using Riverpod.
Main things that this example demonstrates:
I was desperately looking for an example like this to implement in my app but failed to find one.