Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only modify DtrBarEntry.Shown when show state changes #59

Merged
merged 1 commit into from
Jul 18, 2024

Conversation

nebel
Copy link

@nebel nebel commented Jul 17, 2024

A very small change to check the state of DtrBarEntry.Shown before setting it. By doing it this way we avoid setting the internal isDirty flag on the DtrBarEntry each frame and prevent Dalamud from re-rendering the entry when noting has changed.

@slotthhy slotthhy merged commit 2737d2c into slotthhy:main Jul 18, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants