change behavior for remaining kwh #555
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I don't know if I have made the math correct, this language is not what I am used to
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't know if I have made the math correct, this language is not what I am used to
Description
new way to calculate remaining kWh
Motivation and Context
If my battery has 30000 Wh and my end SoC is at 10%.
Today it shows eg. 3 kWh when SoC is at 10% which can be misleading.
How has this been tested
I couldn't test it. I tried to change in -js file in HA but it never worked.
Type of change
Please delete options that are not relevant.
Checklist
package.jsonfollowing semver