Feature/custom_entity #305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new CustomEntity interface allows for streamlined handling of state-related tasks and boilerplate code reduction. Additionally, the full battery capacity computation logic is now encapsulated within the `getBatteryCapacity` method. This promotes better organization and clarity throughout the codebase, particularly in `sunsynk-power-flow-card.js`.
The updated version of sunsynk-power-flow-card.js now incorporates the CustomEntity interface for improved state management and reduced boilerplate code. A part of this change is the enclosed battery capacity computation logic within the `getBatteryCapacity` method, leading to cleaner and more maintainable code. Co-authored-by: Pho3niX90 <[email protected]> Co-authored-by: slipx06 <[email protected]>
The CustomEntity methods were refactored and simplified, reducing the overall complexity and remove unnecessary namespace. This update improves state management and decreases boilerplate code, providing for a cleaner, more maintainable code base. The changes include enclosing battery capacity computation inside the `getBatteryCapacity` method and implementing convertToCustomEntity as a direct export function. Co-authored-by: Pho3niX90 <[email protected]> Co-authored-by: slipx06 <[email protected]>
Co-authored-by: Pho3niX90 <[email protected]> Co-authored-by: slipx06 <[email protected]>
slipx06
reviewed
Mar 12, 2024
Co-authored-by: Pho3niX90 <[email protected]> Co-authored-by: slipx06 <[email protected]>
slipx06
reviewed
Mar 12, 2024
slipx06
reviewed
Mar 12, 2024
Updated the code in src/index.ts by removing the default states for various entities. Default states for 'aux_power_166' and several 'pvX_voltage/current' entities were removed, since they were unnecessary. Additionally, removed the unused 'dynamicConfig' option from sunsynkPowerFlowCardConfig in src/types.ts. Co-authored-by: Pho3niX90 <[email protected]> Co-authored-by: slipx06 <[email protected]>
slipx06
reviewed
Mar 12, 2024
slipx06
reviewed
Mar 12, 2024
|
I'm getting this error
Edit found the problem |
slipx06
reviewed
Mar 13, 2024
| energy: number; | ||
| shutdown_soc: number; | ||
| shutdown_soc_offgrid: number; | ||
| energy: any; |
There was a problem hiding this comment.
Please confirm that I am corrct to change this to any where you can provide a number or sensor
|
@slipx06 should be fixed now, was because I have fixed the state, by changing it to back to string (HassEntity type). |
|
The last update broke battery energy. Its a problem with state_battery_rated_capacity |
slipx06
reviewed
Mar 13, 2024
| battery_energy = Utils.toNum(battery_voltage * state_battery_rated_capacity, 0) | ||
| const battenergy = this.getEntity('battery.energy', {state: config.battery.energy.toString() ?? ''}); | ||
| let battery_energy = battenergy.toNum(0); | ||
| if (battery_voltage && state_battery_rated_capacity.notEmpty()) { |
|
I think this is good to merge now. Is there a better way to handle this error. Happens when you set battery_energy: null
|
|
That should fix it. The optional chaining operator fixes these issues |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new CustomEntity interface allows for streamlined handling of state-related tasks and boilerplate code reduction. Additionally, the full battery capacity computation logic is now encapsulated within the
getBatteryCapacitymethod. This promotes better organization and clarity throughout the codebase.I added the co-authored tag. Although I "think" I got all the logic, I might not have understood the intent at all of the calculations, so just need another pair of eyes.