chore: technical debt #303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Major refactor. Move all consts related to inverters, to their own individual managed classes. This improves the overall readability, as well as making it easier to add new ones. - split out cards to their own classes, for better readability, maintenance, and to reduce IDE memory footprint.
The inverter files are moved to a new 'brands' folder for better organization. The Singleton pattern is implemented in the 'inverter-factory.ts' for efficient instance management. The transformation from inverter settings as an interface to class is also included in this change.
The inverter files are moved to a new 'brands' folder for better organization. The Singleton pattern is implemented in the 'inverter-factory.ts' for efficient instance management. The transformation from inverter settings as an interface to class is also included in this change.
…code_dept # Conflicts: # dist/sunsynk-power-flow-card.js
The battery icon generation and management code has been refactored. The code has been moved to a helper class minimizing redundant code in the main file and allowing for easier future adjustments.
|
Thanks for all the improvements |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
Reduces overall code debt
Improves ease of adding new support for inverters.
Improves IDE memory overhead
This will also make it easier to componentize the 2 cards into smaller components going forward, where there is an overlap of HTML logic. Reduction of similar variable names, and refactoring all variable names into a singular coding standard and naming convention.
How has this been tested
Type of change
Please delete options that are not relevant.