Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compact Mode / Display essential_load1_extra, essential_load2_extra, essential_load3_extra, essential_load4_extra #472

Closed
1 task done
MiniBlister opened this issue Jun 3, 2024 · 5 comments · Fixed by #476
Closed
1 task done

Compact Mode / Display essential_load1_extra, essential_load2_extra, essential_load3_extra, essential_load4_extra #472

MiniBlister opened this issue Jun 3, 2024 · 5 comments · Fixed by #476
Labels
type/feature A minor change

Comments

@MiniBlister
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

In the compact mode the essential_load1_extra, essential_load2_extra, essential_load3_extra, essential_load4_extra is not shown

grafik

Expected behaviour

It seems like there is space to show the values.

Possible Solutions

In case Load1 and Load2 would be moved up by 20 the extra field could be displayed as well.

grafik

Mode

lite

Context / Reason

add additional space between. 20 px should be enough and display the extra fields
@MiniBlister MiniBlister added the type/feature A minor change label Jun 3, 2024
@MiniBlister
Copy link
Contributor Author

Ahh, just realized, that extra3 and extra4 do not exist yet

@slipx06
Copy link
Owner

slipx06 commented Jun 3, 2024

At the moment extra information is only displayed when you have 2 loads. I never added them because of space but I can relook at it.

@MiniBlister
Copy link
Contributor Author

I added load3 and load4 in local copy but still need to work the position. Do you want me to commit the change in case done?

@slipx06
Copy link
Owner

slipx06 commented Jun 3, 2024

Sure. Happy for you to submit a pull request

@MiniBlister
Copy link
Contributor Author

submitted a pull request. Hope this works. Please let me know in case I did something wrong

@MiniBlister MiniBlister mentioned this issue Jun 5, 2024
Merged
11 tasks
slipx06 added a commit that referenced this issue Jun 5, 2024
@slipx06
feat: display extra load information on compact card when additional …
ae6eab5 
…loads = 3 and 4 closes #472

feat: customise the grid icons. See `import_icon:`, `export_icon:`, and `disconnected_icon:` under grid section. Specify mdi or sensor that returns an mdi:icon closes #475 and closes #469
fix: position of grid provider name when Daily Grid Buy is hidden
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/feature A minor change
Projects
None yet
Milestone
No milestone
2 participants
@slipx06 @MiniBlister