chore: better tests (#75)

* chore: remove pycache stuff

* chore: ignore pycache

* fix: async tests now work properly

* chore: only release package if tests pass

* chore: bump version

* chore: enable renovate for python and gh actions

.github/renovate.json

@@ -1,6 +1,6 @@
 {
   "extends": ["config:recommended", "group:all", "schedule:weekly", ":widenPeerDependencies"],
-  "enabledManagers": ["npm"],
+  "enabledManagers": ["pep621", "npm", "github-actions"],
   "packageRules": [
     {
       "matchManagers": ["npm"],
@@ -10,6 +10,10 @@
     {
       "rangeStrategy": "auto",
       "matchPackageNames": ["/npm/"]
+    },
+    {
+      "matchPackagePatterns": ["github-actions"],
+      "automerge": true
     }
   ],
   "timezone": "Europe/Helsinki",

.github/workflows/release.yml

@@ -1,11 +1,17 @@
 on:
-  push:
+  workflow_run:
+    workflows: ['Tests']
+    types:
+      - completed
     branches:
       - main
+  workflow_dispatch:
 
 jobs:
   publish:
     runs-on: ubuntu-latest
+    if: ${{ github.event.workflow_run.conclusion == 'success' }}
+
     steps:
       - uses: actions/[email protected]
       - uses: pnpm/[email protected]

.github/workflows/e2e.yml → .github/workflows/tests.yml

@@ -1,4 +1,4 @@
-name: E2E Test
+name: Tests
 
 on:
   push:
@@ -28,6 +28,7 @@ jobs:
     runs-on: ubuntu-latest
 
     env:
+      CI: 1
       DEBUG: 0
       PLAYWRIGHT_BROWSERS_PATH: 0
 
@@ -49,7 +50,7 @@ jobs:
           cache: 'pnpm'
 
       - name: Install Playwright browsers
-        run: npx playwright install --with-deps
+        run: pnpm exec playwright install --with-deps
 
       - name: Run e2e tests
         run: pnpm test:ci-e2e

.gitignore

@@ -2,6 +2,7 @@
 node_modules
 dist
 dist-ssr
+__pycache__
 
 /tests/e2e/videos/
 /tests/e2e/screenshots/

CHANGES.md

@@ -1,5 +1,9 @@
 # Changelog
 
+## 0.3.1 (2024-11-14)
+
+- Fix: fixed async tests.
+
 ## 0.3.0 (2024-11-14)
 
 - Enhancement: made tests better, added Python api for proper local testing.

package.json

@@ -1,7 +1,7 @@
 {
   "name": "@slipmatio/toolbelt",
   "type": "module",
-  "version": "0.3.0",
+  "version": "0.3.1",
   "main": "dist/toolbelt.umd.cjs",
   "module": "dist/toolbelt.js",
   "exports": {

playwright.config.ts

@@ -5,23 +5,19 @@ const config: PlaywrightTestConfig = {
   testDir: './tests/e2e',
   timeout: 15 * 1000,
   expect: {
-    /**
-     * Maximum time expect() should wait for the condition to be met.
-     * For example in `await expect(locator).toHaveText();`
-     */
     timeout: 3000,
   },
+  fullyParallel: true,
   /* Fail the build on CI if you accidentally left test.only in the source code. */
   forbidOnly: !!process.env.CI,
   /* Retry on CI only */
-  retries: process.env.CI ? 1 : 0,
+  retries: process.env.CI ? 2 : 0,
   /* Opt out of parallel tests on CI. */
-  workers: process.env.CI ? 2 : undefined,
+  workers: process.env.CI ? 1 : undefined,
   use: {
-    actionTimeout: 0,
+    actionTimeout: 500,
     baseURL: 'http://localhost:5173',
     trace: 'on-first-retry',
-    // headless: !!process.env.CI,
   },
   webServer: {
     command: 'vite dev',
@@ -30,25 +26,17 @@ const config: PlaywrightTestConfig = {
   },
   projects: [
     {
-      name: 'iPhone 6',
+      name: 'iPhone SE',
       use: {
         browserName: 'webkit',
-        ...devices['iPhone 6'],
-      },
-    },
-    {
-      name: 'Macbook 11',
-      use: {
-        browserName: 'firefox',
-        ...devices['Macbook 11'],
-        video: 'on-first-retry',
+        ...devices['iPhone SE'],
       },
     },
     {
       name: 'Desktop',
       use: {
-        browserName: 'chromium',
-        ...devices['Macbook Pro'],
+        browserName: 'firefox',
+        ...devices['Desktop Firefox'],
       },
     },
   ],

tests/e2e/browser.spec.ts

@@ -3,7 +3,7 @@ import { expect, test } from '@playwright/test'
 test('clipboard should work', async ({ page }) => {
   await page.goto('/')
   await page.getByTestId('clipboard').click()
-  expect(page.getByTestId('clipboard-result')).toHaveText('true')
+  await expect(page.getByTestId('clipboard-result')).toHaveText('true')
 })
 
 test('getCookie should work', async ({ browser }) => {
@@ -16,12 +16,13 @@ test('getCookie should work', async ({ browser }) => {
   const cookies = await context.cookies()
   expect(cookies).toHaveLength(1)
   await page.waitForSelector('[data-testid=cookie-results]')
-  expect(page.getByTestId('cookie-result1')).toHaveText('null')
-  expect(page.getByTestId('cookie-result2')).toHaveText('this-is-a-test')
+
+  await expect(page.getByTestId('cookie-result1')).toHaveText('null')
+  await expect(page.getByTestId('cookie-result2')).toHaveText('this-is-a-test')
 })
 
 test('localStorage should be available', async ({ page }) => {
   await page.goto('/')
   await page.getByTestId('localstorage').click()
-  expect(page.getByTestId('localstorage-result')).toHaveText('true')
+  await expect(page.getByTestId('localstorage-result')).toHaveText('true')
 })

tests/e2e/vue.spec.ts

@@ -4,7 +4,7 @@ import { testUrls } from '../../src/testurls'
 test('getNextPath should work on all inputs', async ({ page }) => {
   for (const { testid, url, expected } of testUrls) {
     await page.goto(url)
-    expect(page.getByTestId('path')).toHaveText(expected)
+    await expect(page.getByTestId('path')).toHaveText(expected)
     console.log(`url: ${url}, expected: ${expected}`)
   }
 })