CI: Re-enable builds with Nightly Rust #5722
Comments
tronical
added
the
a:ci
tronical
added a commit
that referenced
this issue
Jul 30, 2024
ogoffart
added a commit
that referenced
this issue
Aug 8, 2024
In rust, use f32 instead of f64 for arithmetic comparison. In the interpreter, use approx_eq The test is failling in nightly because of precision change in `log`. By using f32, it actually should work Also Revert "Disable builds with nightly Rust temporarily" This reverts commit 4afc3a2. Fixes #5722
ogoffart
added a commit
that referenced
this issue
Aug 8, 2024
In rust, use f32 instead of f64 for arithmetic comparison. In the interpreter, use approx_eq The test is failling in nightly because of precision change in `log`. By using f32, it actually should work Also Revert "Disable builds with nightly Rust temporarily" This reverts commit 4afc3a2. Fixes #5722
ogoffart
added a commit
that referenced
this issue
Aug 8, 2024
In rust, use f32 instead of f64 for arithmetic comparison. In the interpreter, use approx_eq The test is failling in nightly because of precision change in `log`. By using f32, it actually should work Also Revert "Disable builds with nightly Rust temporarily" This reverts commit 4afc3a2. Fixes #5722
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Until rust-lang/rust#128386 is resolved, the build with nightly Rust is disabled. It should be our objective to re-enable testing with nightly when either this is fixed upstream or we have changed our code to pass tests (
test_interpreter_expr_mathfailed, also with test-driver-rust).The text was updated successfully, but these errors were encountered: