fix: --download option should affect getDefine (#1937)

slidevjs · Nov 10, 2024 · 688e9cf · 688e9cf
1 parent b1f3cd4
commit 688e9cf
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 3 deletions.
diff --git a/packages/slidev/node/cli.ts b/packages/slidev/node/cli.ts
@@ -351,9 +351,7 @@ cli.command(
     const { build } = await import('./commands/build')
 
     for (const entryFile of entry as unknown as string[]) {
-      const options = await resolveOptions({ entry: entryFile, theme, inspect }, 'build')
-      if (download && !options.data.config.download)
-        options.data.config.download = download
+      const options = await resolveOptions({ entry: entryFile, theme, inspect, download }, 'build')
 
       printInfo(options)
       await build(

diff --git a/packages/slidev/node/options.ts b/packages/slidev/node/options.ts
@@ -32,6 +32,9 @@ export async function resolveOptions(
   const addonRoots = await resolveAddons(config.addons)
   const roots = uniq([...themeRoots, ...addonRoots, rootsInfo.userRoot])
 
+  if (entryOptions.download)
+    config.download ||= entryOptions.download
+
   debug({
     ...rootsInfo,
     ...entryOptions,

diff --git a/packages/types/src/options.ts b/packages/types/src/options.ts
@@ -30,6 +30,11 @@ export interface SlidevEntryOptions {
    * Enable inspect plugin
    */
   inspect?: boolean
+
+  /**
+   * Build with --download option
+   */
+  download?: boolean
 }
 
 export interface ResolvedSlidevOptions extends RootsInfo, SlidevEntryOptions {