Post-Processing Script Parameters #4363
Conversation
Any whitespace is the boundrary between the args/filename. Whitespace can be escaped by putting a exxclamation point in front of it. And exclamation points can be escaped by putting an exclamation point in front of the exclamation point to be escaped. I thought about adding another box for arguments, but I think that would make it more confusing to use. The only worry I have with this method is peoples existing scripts with whitespace in the name.
|
Just as well! :-) |
|
Yeah that works just fine.
|
|
I will take a look at it tonight and make any recommendations as necessary. Thanks for the PR. |
|
Downloaded the "artifacts" from here: https://ci.appveyor.com/project/lordofhyphens/slic3r/build/1.3.0-master-1639/ and tested with Windows 7 x64 => works. @lordofhyphens: as far as I'm concerned, you can close #4325 and merge this PR. |
|
About the only thing I could want would be a regression test (to make sure that if someone manages to break it again the future we notice immediately). |
|
Yeah, looks pretty good. Thank you @TheThirdOne . |
This is a solution to #4000.
I didn't realize this before I finished, but #4325 also solves the issue (it did remind me that \ is a poor escaping character for windows). However, that solution prevents ! from being using in any of the arguments or executable name. This one instead splits on whitespace and allows escaping whitespace so it doesn't prevent any filename from being expressed.
Examples:
/path/to/executablebecomes/path/to/executablewith the argoutputfilename.gcode/path/to/executable -arg -arg2becomes/path/to/executablewith args-arg,-arg2, andoutputfilename.gcode/path/to/executable! with! spaces -arg -arg2becomes/path/to/executable with spaceswith args-arg,-arg2, andoutputfilename.gcode/path/to/executable!! -arg -arg2becomes/path/to/executable!with args-arg,-arg2, andoutputfilename.gcodeThe escaping is solved robustly so it should work exactly as programmers would expect (but with ! instead of \ because of Windows). But non programmers may not find it as obvious and people with existing post processing scripts that have whitespace in them may be surprised by their script breaking.
I haven't testing on Windows, but I don't see why it shouldn't work.